Bump vendored kubernetes to v1.12.3

[dkoshkin]

Is this a bug fix or adding new feature?
Bug fix

What is this PR about? / Why do we need it?
When trying to test and build locally I get:

➜  aws-ebs-csi-driver git:(master) make test
go test -v -race ./pkg/...
go: verifying k8s.io/[email protected]: checksum mismatch
	downloaded: h1:JEj2cxR+5T31U4klP5hI5dxjr6udRIHm+4dzCEPk498=
	go.sum:     h1:J94sY8nziFyzMNhnbD5CiSZTo7yWytir0ia+vJuwYfc=
make: *** [test] Error 1
➜  aws-ebs-csi-driver git:(master) go version
go version go1.11.2 darwin/amd64

I'm not really sure why this works in CI and when running make image, maybe its a darwin thing 🤷‍♂️.

If I delete mod.sum and recreate it, the hash for k8s.io/kubernetes is different

-k8s.io/kubernetes v1.12.2 h1:J94sY8nziFyzMNhnbD5CiSZTo7yWytir0ia+vJuwYfc=
+k8s.io/kubernetes v1.12.2 h1:JEj2cxR+5T31U4klP5hI5dxjr6udRIHm+4dzCEPk498=

Either way, Kubernetes 1.12.3 is out with a fix for a major vulnerability and bumping up the version fixes this mod issue also.

What testing is done?
After updating to the new version:

➜  aws-ebs-csi-driver git:(vendored-kubernetes) make
mkdir -p bin
CGO_ENABLED=0 GOOS=linux go build -ldflags "-X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.driverVersion=0.1.0-alpha -X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.gitCommit=643014b968afff5cff6909ace80f7de56861291e -X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.buildDate=2018-12-05T19:24:56Z" -o bin/aws-ebs-csi-driver ./cmd/
➜  aws-ebs-csi-driver git:(vendored-kubernetes) echo $?
0
➜  aws-ebs-csi-driver git:(vendored-kubernetes) make test
go test -v -race ./pkg/...
...
➜  aws-ebs-csi-driver git:(vendored-kubernetes) echo $?
0

[k8s-ci-robot]

Hi @dkoshkin. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[leakingtapan]

/ok-to-test

[leakingtapan]

@dkoshkin which go version are you using? Now travis job failed with similar error message

[leakingtapan]

Could be related to this old issue: golang/go#27925

[dkoshkin]

@leakingtapan Im using:

➜  aws-ebs-csi-driver git:(master) go version
go version go1.11.2 darwin/amd64

I see you have already commented on that issue, what version are you using?

Looks like the hash is different for Linux and Darwin from this comment.

[leakingtapan]

I see you have already commented on that issue, what version are you using?

Im using go version go1.11 darwin/amd64

Could you try bump the go version in our traivs build to see if it helps?

[bertinatto]

Strange, I'm using go version go1.11.2 linux/amd64 and I don't get any errors.

If I delete mod.sum and recreate it, the hash for k8s.io/kubernetes is different

Yeah, this happened to me many times in the past. I thought it was fixed in 1.11.2 because it ceased to happen for me.

-k8s.io/kubernetes v1.12.2 h1:J94sY8nziFyzMNhnbD5CiSZTo7yWytir0ia+vJuwYfc=
+k8s.io/kubernetes v1.12.2 h1:JEj2cxR+5T31U4klP5hI5dxjr6udRIHm+4dzCEPk498=

I'm surprised that you didn't get v1.13 instead (since you deleted go.[mod,sum]).

[dkoshkin]

@leakingtapan, @bertinatto so it does look like its a Go 1.11.1 issue, but requires to clean cache - golang/go#27925 (comment).

The issue was being caused due to the version differences between our dev machines (go 1.11.2), and the fact that the builder image and Travis were both still on Go 1.11.1, I've updated both of those versions and CI passed.

I was also able to reproduce this issue locally:
Running make in below container will fail, switching to 1.11.2 builds correctly.

docker run -v `pwd`:`pwd` -w `pwd` -i -t golang:1.11.1

Also let me know if you want me to modify this PR to update to Kubernetes 1.13, but that seems a little risky as it was just released.

[leakingtapan]

Also let me know if you want me to modify this PR to update to Kubernetes 1.13, but that seems a little risky as it was just released.

We could do it later to not embrace the risk all at once

[leakingtapan]

/lgtm

[leakingtapan]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkoshkin, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [leakingtapan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 225

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 51.596%

---

Totals
Change from base Build 220:	0.0%
Covered Lines:	582
Relevant Lines:	1128

---

💛 - Coveralls