revise preqs for install docs #1389
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
docs/install.md
Outdated
| @@ -1,12 +1,15 @@ | |||
| # Installation | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| * Kubernetes Version >= 1.20 | |||
| * Versions 1.18 - 1.19 may require the `VolumeSnapshotDataSource` feature gate be enabled on `kubelet`. | |||
There was a problem hiding this comment.
1.18 and 1.19 are long EOL and not even supported by EKS anymore, maybe we can finally just drop the extra note?
There was a problem hiding this comment.
I agree in spirit, but you can still create new 1.19 clusters on EKS.
https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
There was a problem hiding this comment.
When I go to create a cluster in the console, it doesn't give 1.19 as an option. Is it possible those docs are out of date? Or maybe it's possible only via the CLI/API for some reason?
There was a problem hiding this comment.
the docs are out of date...... so yes now i'm fine removing it.
k8s-ci-robot
added
the
lgtm
geoffcline
force-pushed
the
gdc-patch-2
branch
from
dffe2eb to
a4cc408
Compare
k8s-ci-robot
added
approved
|
It has been squashed @torredil :) thanks |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3, geoffcline, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
users were confused about the preq steps about checking feature gates.
What is this PR about? / Why do we need it?
these need for enabling these gates is largely outdated. it is also clearer to discribe the version directly.
What testing is done?