Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set handle-volume-inuse-error to false #1280

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Set handle-volume-inuse-error to false #1280

merged 1 commit into from
Jun 20, 2022

Conversation

stijndehaes
Copy link
Contributor

If online resizing is supported this should
be set to false. Otherwise, the resizer
will watch pods and use a lot more memory.

Is this a bug fix or adding new feature?
This fixes: #1248

What is this PR about? / Why do we need it?

It set's the check to see if the volume is in use to false. This should only be turned on
when the volume supports live resizing. I believe EBS volumes support resizing when in use.

What testing is done?
This setting is used in other csi implementations

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @stijndehaes!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @stijndehaes. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot requested review from gnufied and torredil June 20, 2022 07:15
@torredil
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2022
torredil
torredil requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@torredil torredil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution! Can you please also include this change in deploy/kubernetes/base/controller.yaml? thanks.

@stijndehaes
Set handle-volume-inuse-error to false
ebc07c6 
If online resizing is supported this should
be set to false. Otherwise, the resizer
will watch pods and use a lot more memory.
@stijndehaes stijndehaes force-pushed the feature/resizer-handle-volume-inuse-error branch from 698d6fb to ebc07c6 Compare June 20, 2022 12:16
@stijndehaes
Copy link
Contributor Author

Hi, thank you for your contribution! Can you please also include this change in deploy/kubernetes/base/controller.yaml? thanks.

Yeah no problem! I added it to the PR

@torredil
Copy link
Member

/retest-required

@torredil torredil added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022
@torredil
Copy link
Member

Thanks!
/lgtm
/approve
cc @gtxu @rdpsin

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stijndehaes, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rdpsin
Copy link
Contributor

rdpsin commented Jun 20, 2022

/lgtm

@ghost
Copy link

ghost commented Jun 20, 2022

/lgtm
/meow

@k8s-ci-robot
Copy link
Contributor

@MurphyPuppy: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@MurphyPuppy: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gtxu
Copy link
Contributor

gtxu commented Jun 20, 2022

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8f907f7 into kubernetes-sigs:master Jun 20, 2022
@stijndehaes
Copy link
Contributor Author

@torredil Hey I saw master branch failing because the helm chart has the same version. Did I have to update the helm charts version in my PR? I can make a second PR to update the version if that would help :)

@torredil
Copy link
Member

@stijndehaes No worries! We are currently working on releasing v1.7.0 and will bump up the Helm chart version as part of the release process. Thanks :)

@blair-small blair-small mentioned this pull request Jun 22, 2022
Merged
@ialidzhikov ialidzhikov mentioned this pull request Jun 23, 2022
Merged
@foxdalas foxdalas mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@rdpsin rdpsin

@gtxu gtxu

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csi-resizer getting OOMKilled
5 participants
@stijndehaes @k8s-ci-robot @torredil @rdpsin @gtxu