-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1182 quote extra tags arg #1198
1182 quote extra tags arg #1198
Conversation
Welcome @Kaezon! |
Hi @Kaezon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Trying to get the CLA taken care of ASAP |
/ok-to-test |
Finally got feedback from legal and signed the CLA. Sorry for the wait. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaezon, rdpsin, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Is this a bug fix or adding new feature?
Bug fix for #1182
What is this PR about? / Why do we need it?
This fix add quotes around the extra-tags argument in order to prevent special characters such as ":" from breaking the manifest YAML after template rendering.
What testing is done?
Manual test with "helm template" to validate render output, as well as a live deployment to make sure a deployment would run with the offending tag value.