Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PodDisruptionBudget api version for kubernetes 1.21+ #1196

Conversation

wangshu3000
Copy link
Contributor

Is this a bug fix or adding new feature?
This is an API upgrade PR.

What is this PR about? / Why do we need it?
This is a PR to upgrade PDB api version for kubernetes 1.21+
The policy/v1beta1 api version will not be supported after kubernetes 1.25+. So we need to upgrade this version.
Use policy/v1 for k8s 1.21+, to avoid displaying any warning of deprecated api version.

This PR is related to below issue:
#1184

What testing is done?
Tested on different kubernetes version in minikube.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wangshu3000 / name: Shu.Wang (fc31b44)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @wangshu3000!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @wangshu3000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2022
@gtxu
Copy link
Contributor

gtxu commented Apr 1, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2022
@gtxu
Copy link
Contributor

gtxu commented Apr 1, 2022

Hi @wangshu3000 Would you please update your CLA? Thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 2, 2022
@wangshu3000
Copy link
Contributor Author

Hi @wangshu3000 Would you please update your CLA? Thanks!

@gtxu Just updated CLAs. Thanks.

@zerkms
Copy link
Contributor

zerkms commented Apr 4, 2022

The suggested implementation is not portable, instead a comparison with api versions should be used:

{{ if $.Capabilities.APIVersions.Has "policy/v1/PodDisruptionBudget" -}}

@wangshu3000
Copy link
Contributor Author

wangshu3000 commented Apr 4, 2022

i check k8s version, because for new version of helm, if people use helm template to generate yaml offline. The APIVersion.Has can not return the accuate api version, this happend in other repo previously, if it's ok for this repo then let me update it, thanks.

@zerkms
Copy link
Contributor

zerkms commented Apr 4, 2022

It's the opposite: helm template DOES NOT have reliable version available, but you may have capabilities mocked: https://helm.sh/docs/helm/helm_template/

Also for example look at

{{- if or (.Capabilities.APIVersions.Has "snapshot.storage.k8s.io/v1beta1") (.Capabilities.APIVersions.Has "snapshot.storage.k8s.io/v1") }}

@wangshu3000
Copy link
Contributor Author

It's the opposite: helm template DOES NOT have reliable version available, but you may have capabilities mocked: https://helm.sh/docs/helm/helm_template/

Also for example look at

{{- if or (.Capabilities.APIVersions.Has "snapshot.storage.k8s.io/v1beta1") (.Capabilities.APIVersions.Has "snapshot.storage.k8s.io/v1") }}

Aha. You are right, i remember it wrongly. Just updated, thanks for pointing it out.

@gtxu
Copy link
Contributor

gtxu commented Apr 8, 2022

/lgtm
/approve
@wangshu3000 Thank you for the contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtxu, wangshu3000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6d1e283 into kubernetes-sigs:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants