-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PodDisruptionBudget api version for kubernetes 1.21+ #1196
Upgrade PodDisruptionBudget api version for kubernetes 1.21+ #1196
Conversation
|
Welcome @wangshu3000! |
Hi @wangshu3000. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi @wangshu3000 Would you please update your CLA? Thanks! |
@gtxu Just updated CLAs. Thanks. |
The suggested implementation is not portable, instead a comparison with api versions should be used:
|
i check k8s version, because for new version of helm, if people use helm template to generate yaml offline. The APIVersion.Has can not return the accuate api version, this happend in other repo previously, if it's ok for this repo then let me update it, thanks. |
It's the opposite: Also for example look at
|
… PodDsruptionBudget
Aha. You are right, i remember it wrongly. Just updated, thanks for pointing it out. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtxu, wangshu3000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
This is an API upgrade PR.
What is this PR about? / Why do we need it?
This is a PR to upgrade PDB api version for kubernetes 1.21+
The policy/v1beta1 api version will not be supported after kubernetes 1.25+. So we need to upgrade this version.
Use policy/v1 for k8s 1.21+, to avoid displaying any warning of deprecated api version.
This PR is related to below issue:
#1184
What testing is done?
Tested on different kubernetes version in minikube.