Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform agnostic device removal #1193

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

torredil
Copy link
Member

Signed-off-by: Eddie Torres [email protected]

Is this a bug fix or adding new feature?

  • The current device removal process in the driver is not working correctly for Windows customers as provisioned volumes can get stuck in the detachment process.
  • In the current implementation, volumes are unstaged and unpublished by calling the Unmount function from the "k8s.io/mount-utils" package. On Windows, this function executes cmd rmdir ${target} which does not guarantee a successful volume unstage and graceful device removal.

What is this PR about? / Why do we need it?

  • The device removal process is improved on Windows by using the CSI Proxy API to flush the data cache and remove the global staging path.
  • The disk is offlined to ensure graceful device removal as per EC2 documentation.
  • Some general refactoring is done to improve code quality and ensure implementation is platform agnostic.

What testing is done?

make test succeeds.

  1. Build and upload container images to a registry.
  2. Change the image in the helm chart.
  3. Test unmounting functionality using the new helm chart.

@gtxu
Copy link
Contributor

gtxu commented Mar 25, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 25, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2022
@torredil torredil force-pushed the device-unmounting branch from 98f2212 to 019dd49 Compare March 26, 2022 01:51
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2022
@torredil torredil force-pushed the device-unmounting branch from 019dd49 to 353404d Compare March 26, 2022 02:07
@gtxu
Copy link
Contributor

gtxu commented Mar 28, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@gtxu
Copy link
Contributor

gtxu commented Mar 28, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtxu, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit a304d3e into kubernetes-sigs:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants