Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows NodePublish failing because mount target doesn't exist #1081

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Oct 6, 2021

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it? on windows it is normal for the mount target not to exist. Added comment:

// Do not return os.IsNotExist error. Other errors were handled above. It is
// the responsibility of the caller to check whether the given target path
// exists (in Linux, the target mount directory must exist before mount is
// called on it) or not (in Windows, the target must NOT exist before a
// symlink is created at it)

What testing is done? tested on my EKS 1.20 cluster

Built image

OUTPUT_TYPE=registry OS=windows OSVERSION=1809 TAG=oct6-0 REGISTRY=x.dkr.ecr.us-west-2.amazonaws.com make image

Edited the daemonset to use my image and bump verbosity to 5
k edit daemonset ebs-csi-node-windows -n kube-system

Scaled my windows deployment up

k scale deployment windows-server-iis --replicas 1

Checked my volume is readable.

k exec -it windows-server-iis-7c5fc8f6c5-9rfhz powershell
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved. 

PS C:\> ls data 


    Directory: C:\data 


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----         7/8/2021   8:05 PM              3 testfile1.txt

@wongma7 wongma7 requested a review from nirmalaagash October 6, 2021 19:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@wongma7 wongma7 force-pushed the windowsregressfix branch from 27215b0 to a8ae363 Compare October 6, 2021 19:54
@nirmalaagash
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Oct 7, 2021

/test pull-aws-ebs-csi-driver-verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants