Fix windows NodePublish failing because mount target doesn't exist #1081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? /bug
What is this PR about? / Why do we need it? on windows it is normal for the mount target not to exist. Added comment:
// Do not return os.IsNotExist error. Other errors were handled above. It is
// the responsibility of the caller to check whether the given target path
// exists (in Linux, the target mount directory must exist before mount is
// called on it) or not (in Windows, the target must NOT exist before a
// symlink is created at it)
What testing is done? tested on my EKS 1.20 cluster
Built image
Edited the daemonset to use my image and bump verbosity to 5
k edit daemonset ebs-csi-node-windows -n kube-system
Scaled my windows deployment up
Checked my volume is readable.