[release-1.2] Build and push multi-arch/os (amazon and windows, no debian) image manifest via Make rules #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nifest via Make rules
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
nckturner
approved these changes
Sep 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@nckturner we rely on stuff like mkfs.ext4 and such and so we just install those using yum + amazonlinux base image. something like this https://github.com/aws/eks-distro-build-tooling where the minimum binaries/libs are copied from an amazonlinux base image in to a distroless image is possible but requires some effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it? cherry-pick of #957 on to release-1.2 branch
The main motivation is to mitigate the slow builds in this branch #1048 . Building amazonlinux + windows manifest using this Makefile is faster than building amazonlinux + debian manifest using the old Makefile I suspect because the old one wastes a lot of time doing multi-platform binary builds while virtualizing the platforms whereas this one leverages --platform=$BUILDPLATFORM and GOOS to multi-platform binaries on x86.
What testing is done? I will check after this merges if the release-1.2 branch prow build finishes within an hour or not.