Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] Increase prow timeout to 1h15m #1049

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Sep 9, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? This is a bandaid fix to get 1.1.4 out. Our build time has been steadily increasing and now it consistently breaches the 1h timeout. https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/aws-ebs-csi-driver-push-images. It was already very slow before compared to github actions (30-45 mins vs 15mins) so it will need to be fixed, tracking it here: #1048

for comparison master branch is still pretty slow at 40 mins but it building for windows in addition to x86 and arm! So one option to solve #1048 is to backport the Makefile/Dockerfile/build changes to release-1.1 branch.

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021
@nckturner
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5510b07 into kubernetes-sigs:release-1.1 Sep 9, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Sep 9, 2021

Test started today at 10:40 AM passed after 1h4m6s. (more info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants