Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github build failing because of wrong docker hub registry name #1016

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 9, 2021

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it?
build is failing. There is no "library" in the registry name https://github.com/kubernetes-sigs/aws-ebs-csi-driver/runs/3256645072

What testing is done? locally can pull from docker.io/amazon but not docker.io/library/amazon, the former is the correct one.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2021
@k8s-ci-robot k8s-ci-robot requested a review from ddebroy August 9, 2021 18:33
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from gnufied August 9, 2021 18:33
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2021
@wongma7 wongma7 changed the title Fix docker hub registry name Fix github build failing because of wrong docker hub registry name Aug 9, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 9, 2021

/test pull-aws-ebs-csi-driver-external-test-eks

@AndyXiangLi
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0335907 into kubernetes-sigs:master Aug 10, 2021
k8s-ci-robot added a commit that referenced this pull request Sep 17, 2021
[release-1.2] Fix gcr prow and github builds: cherry-pick of #1016, #1017, and #1020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants