Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart: can't annotate storage classes #733

Closed
nicholasmhughes opened this issue Feb 9, 2021 · 0 comments
Closed

Helm chart: can't annotate storage classes #733

nicholasmhughes opened this issue Feb 9, 2021 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@nicholasmhughes
Copy link
Contributor

/kind bug

What happened?
The new ability to create storage classes within the chart is great. However, there isn't a mechanism to annotate the storage classes. This becomes important is you want to tag one as default.

What you expected to happen?
Annotations should be handled separately from the rest of the storage class YAML and inserted under metadata.

How to reproduce it (as minimally and precisely as possible)?

storageClasses:
  - name: ebs-sc
    annotations:
      storageclass.kubernetes.io/is-default-class: "true"

Anything else we need to know?:
I have the code for this. PR inbound.

Environment

  • Kubernetes version (use kubectl version): v1.18.12
  • Driver version: 0.9.0
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 9, 2021
nicholasmhughes added a commit to nicholasmhughes/aws-ebs-csi-driver that referenced this issue Feb 9, 2021
@nicholasmhughes
closes kubernetes-sigs#733; add storage class annotation and label ha…
11d9475 
…ndling to chart
@nicholasmhughes nicholasmhughes mentioned this issue Feb 9, 2021
Merged
nicholasmhughes added a commit to nicholasmhughes/aws-ebs-csi-driver that referenced this issue Feb 18, 2021
@nicholasmhughes
closes kubernetes-sigs#733; add storage class annotation and label ha…
1fc7b00 
…ndling to chart
nicholasmhughes added a commit to nicholasmhughes/aws-ebs-csi-driver that referenced this issue Feb 18, 2021
@nicholasmhughes
closes kubernetes-sigs#733; add storage class annotation and label ha…
927fe69 
…ndling to chart
vdhanan pushed a commit to vdhanan/aws-ebs-csi-driver that referenced this issue Feb 26, 2021
@nicholasmhughes
closes kubernetes-sigs#733; add storage class annotation and label ha…
3332f4c 
…ndling to chart
ArchiFleKs added a commit to particuleio/charts that referenced this issue Mar 5, 2021
@ArchiFleKs
Squashed 'aws-ebs-csi-driver/' changes from 4790c45471..ee3b46c279
5e5163c 
ee3b46c279 Merge pull request #776 from AndyXiangLi/not-tolerate-all-taint
daa2555262 Merge pull request #778 from tsunny/tsunny/remove-prestophook
a724307db1 add toleration time to NoExecute effect
1dbc8acfcd Merge pull request #777 from vdhanan/lockfile
6e59160eea Removing prestop hook for node-driver-registrar
7c1de6f013 go mod tidy
f013880f63 Merge pull request #774 from AndyXiangLi/add-self-as-approver
bc33f06696 add self as reviewer
c07e65470a Merge pull request #751 from vdhanan/master
1e644f81d6 Merge remote-tracking branch 'upstream/master'
25c0e590e5 add readiness probe and bump helm chart version
a3a0bc328e Merge pull request #768 from people-ai/master
75038e8d1b Merge branch 'master' into master
5241bed348 Merge pull request #772 from ayberk/patch-4
208bcf0172 Update chart version
ca5d05e54b Merge pull request #770 from arcivanov/chart_tscs
c159142a35 Merge pull request #765 from rubroboletus/master
1ca1f8bf25 Merge pull request #762 from nvnmandadhi/master
69000c93c6 Merge pull request #771 from AndyXiangLi/delete-volume-on-leak
fc70a3846f Merge pull request #756 from mowangdk/upgrade_livenessprobe_version
5b2faf99c7 delete leaked volume if driver don't know the volume status
0bdb9a6ed3 Bumped chart version
5b31c9334b Merge pull request #767 from jsafrane/fix-iops-param-error
25193d74c3 Add ability to specify topologySpreadConstraints
dd696f1f23 Merge pull request #769 from josselin-c/master
1ef44be8c4 Aws client config: increase MaxRetries
ea61adeffa Fix error message when IOPSPerGB is missing in io1 volumes
ffed9c62b7 Allow setting http proxy and no proxy environment values
341eb8b77f removed harcoded NAMESPACE
4d783ddaae Update livenessprobe image version from 2.1.0 to 2.2.0
69535ad954 Merge pull request #755 from mtougeron/image-pull-secrets
7cf4d1b3d3 add a document separator for storageclass template file
ae12a26bf9 Merge pull request #759 from ayberk/patch-4
7d5601786a Update test k8s version to 1.18.16
40ab0bd52f Use the imagePullSecrets if set
6b8257af1d Merge pull request #752 from mtougeron/helm-set-default-enableVolumeScheduling-to-true
061a9c5f2d bump the chart version
786dbfa5e5 Merge branch 'master' into helm-set-default-enableVolumeScheduling-to-true
2c7a0d127a Merge pull request #702 from AndyXiangLi/node-concurrent-issue
5828d42515 Merge pull request #734 from nicholasmhughes/add-storage-class-annotations
8171f836db Merge branch 'master' into add-storage-class-annotations
bebc32bfa5 closes kubernetes-sigs/aws-ebs-csi-driver#733; add storage class annotation and label handling to chart
8155fe8ed4 Refactor inFlight key to add lock per volumeId for node service
1a15fcc8ff Merge pull request #744 from chrishenzie/create-volume-idempotency
7556d0baeb Set enableVolumeScheduling to true by default in the helm chart
8cf86b7c42 Make CreateVolume idempotent
c547161652 Merge pull request #711 from ig0rsky/master
78d23ca81c add snapshot controller variables
85699e170f Merge pull request #745 from ayberk/ecr_overlay
e2de85d3a4 Update ECR overlay
21fe2a87d3 Merge pull request #742 from AndyXiangLi/update-gcr-image-kustomization
41d8f2e262 correct kustomization gcr image repo
f5172422f6 Merge pull request #740 from AndyXiangLi/update-gcr-image-kustomization
288c177395 patch stable release to use gcr image
62ebcbfa83 Merge pull request #735 from PhilThurston/patch-1
d22d0db501 Merge pull request #732 from dntosas/allow-resources-override-for-node
5b1bb6a972 Updated installation to use latest 0.9 release
5a03305031 [chart] Ability to add priorityClassName
f3a57d3042 [chart] Allow resources override for node DaemonSet

git-subtree-dir: aws-ebs-csi-driver
git-subtree-split: ee3b46c279b57ee778b604a686168caa6764432b
AndyXiangLi pushed a commit to AndyXiangLi/aws-ebs-csi-driver that referenced this issue Mar 5, 2021
@nicholasmhughes @AndyXiangLi
closes kubernetes-sigs#733; add storage class annotation and label ha…
7f62cb9 
…ndling to chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicholasmhughes @k8s-ci-robot