Add Storage Class to static_provisioning example

[pptb-aws]

Is your feature request related to a problem?/Why is this needed
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The static_provisioning example does not have a storageclass in the example. This may result in confusion for people when looking at this example when all others have storageclasses.

/feature

Describe the solution you'd like in detail
A clear and concise description of what you want to happen.

Add a storageclass object to the example.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

If there is a reason not to include a storageclass, please add it to the readme

Additional context
Add any other context or screenshots about the feature request here.

[gtxu]

/good-first-issue

[k8s-ci-robot]

@gtxu:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

why? i removed it for precisely the same reason, because it is confusing #794. storageclass dictates how volumes get dynamically provisioned. In the static provisioning case, it does not do anything

[pptb-aws]

Why I attempt to run the example without a storage class I get this error in the pvc,

Events:
  Type    Reason         Age                From                         Message
  ----    ------         ----               ----                         -------
  Normal  FailedBinding  13s (x5 over 59s)  persistentvolume-controller  no persistent volumes available for this claim and no storage class is set

Running in EKS 1.21 with managed nodegroup.

Reproduction steps,

1. get the example.yaml file, update the volumeHandle in the pv to use a pre-created volume created using the CLI
2. run using kubectl apply -f example.yaml

After some testing the fix is either to add a StorageClass or to add, volumeName: test-pv, to the pvc. I am inclined to agree that not using the StorageClass does highlight a feature of static provisioning. Please let me know if you agree @wongma7.

[torredil]

Hi @pptb-aws thanks for your feedback. Recent changes were made that address this issue. Can you please try out the static provisioning example with the updated instructions/manifest files and provide further feedback? Thanks.

[pptb-aws]

instructions work for me. I am closing this, thank you for the explanations and assistance.