-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade github.com/prometheus/client_golang to help unblock dependabot. #661
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @cheftako |
122d7ad
to
7b3f04c
Compare
/test pull-apiserver-network-proxy-make-lint-master |
Rerunning lint to see if the new kubekins image has helped with the lint error. |
/test pull-apiserver-network-proxy-make-lint-master |
@jkh52: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
FYI: We reverted the problematic change in https://github.com/prometheus/client_golang/releases/tag/v1.20.5, sorry for pain! |
Thanks for the heads up! I verified that v1.20.5 resolves our dependabot issue. I will close this workaround PR. |
Help unblock dependabot and enable the 0.31 release.
$ go get github.com/prometheus/[email protected]
$ go mod tidy
$ go mod vendor
Fix test fallout.