Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dockerfiles (and make targets) to use cross-compile. #579

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Mar 8, 2024

Continue supporting ARCH env for backward compat, but introduce {BUILDARCH, TARGETARCH}.

This is a big speedup, compared to qemu. On my 10y old machine, make docker-build-all took less than 5m. For comparison, see historical latency (source: #274):

Time consumed for each arch:

arm: 1h28m59s
amd64: 2m13s
arm64:16m2s
ppc64le: 19m17s
s390x: 14m14s

At #572 we already changed the dockerfiles (support GO_TOOLCHAIN and GO_VERSION). It would be nice to group this additional change together (add to release-0.30).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from elmiko March 8, 2024 23:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ipochi March 8, 2024 23:21
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@jkh52 jkh52 force-pushed the cross-compile branch 2 times, most recently from a030649 to 9c8b55d Compare March 8, 2024 23:39
Makefile Show resolved Hide resolved
@jkh52 jkh52 force-pushed the cross-compile branch 4 times, most recently from b2c8c8e to 204e317 Compare March 10, 2024 06:31
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 11, 2024

/assign @mainred

@k8s-ci-robot
Copy link
Contributor

@jkh52: GitHub didn't allow me to assign the following users: mainred.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mainred

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Continue supporting ARCH env for backward compat, but introduce {BUILDARCH, TARGETARCH}.
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 11, 2024

/test all

@k8s-ci-robot
Copy link
Contributor

@jkh52: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

  • /test pull-apiserver-network-proxy-docker-build-amd64-master
  • /test pull-apiserver-network-proxy-docker-build-arm64-master
  • /test pull-apiserver-network-proxy-make-lint-master
  • /test pull-apiserver-network-proxy-test-master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkh52
Copy link
Contributor Author

jkh52 commented Mar 11, 2024

/test pull-apiserver-network-proxy-docker-build-amd64-master
/test pull-apiserver-network-proxy-docker-build-arm64-master
/test pull-apiserver-network-proxy-make-lint-master
/test pull-apiserver-network-proxy-test-master

@jkh52
Copy link
Contributor Author

jkh52 commented Mar 11, 2024

Flake:

--- FAIL: TestProxyDial_RequestCancelled_Concurrent_GRPC (61.95s)
    proxy_test.go:399: Timed out waiting for tunnel to close
    proxy_test.go:426: Agent connections leaked: 
        
        Diff:
        --- metric output does not match expectation; want
        +++ got:
        @@ -2,3 +2,3 @@
         # TYPE konnectivity_network_proxy_agent_open_endpoint_connections gauge
        -konnectivity_network_proxy_agent_open_endpoint_connections 0
        +konnectivity_network_proxy_agent_open_endpoint_connections 1

/retest

@tallclair
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 26b0440 into kubernetes-sigs:master Mar 12, 2024
10 checks passed
@jkh52 jkh52 mentioned this pull request Mar 12, 2024
jkh52 added a commit to jkh52/apiserver-network-proxy that referenced this pull request Apr 9, 2024
kubernetes-sigs#579 inadvertently broke the examples/kind/README.md workflow.

Note that the static konnectivity-server.yaml and konnectivity-agent.ds.yaml are re-used (by 1. manual getting started instructions, which pulls the latest published images, and 2. Github Action tests at .github/workflows/e2e.yaml).
jkh52 added a commit to jkh52/apiserver-network-proxy that referenced this pull request Apr 9, 2024
kubernetes-sigs#579 inadvertently broke the examples/kind/README.md instructions.

Note that the static konnectivity-server.yaml and konnectivity-agent.ds.yaml are re-used (by 1. manual getting started instructions, which pulls the latest published images, and 2. Github Action tests at .github/workflows/e2e.yaml).
jkh52 added a commit to jkh52/apiserver-network-proxy that referenced this pull request Apr 9, 2024
kubernetes-sigs#579 inadvertently broke the examples/kind/README.md instructions.

Note that the static konnectivity-server.yaml and konnectivity-agent.ds.yaml are re-used (by 1. manual getting started instructions, which pulls the latest published images, and 2. Github Action tests at .github/workflows/e2e.yaml).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants