-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Dockerfiles (and make targets) to use cross-compile. #579
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a030649
to
9c8b55d
Compare
b2c8c8e
to
204e317
Compare
/assign @mainred |
@jkh52: GitHub didn't allow me to assign the following users: mainred. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Continue supporting ARCH env for backward compat, but introduce {BUILDARCH, TARGETARCH}.
/test all |
@jkh52: No jobs can be run with
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-apiserver-network-proxy-docker-build-amd64-master |
Flake:
/retest |
/lgtm |
kubernetes-sigs#579 inadvertently broke the examples/kind/README.md workflow. Note that the static konnectivity-server.yaml and konnectivity-agent.ds.yaml are re-used (by 1. manual getting started instructions, which pulls the latest published images, and 2. Github Action tests at .github/workflows/e2e.yaml).
kubernetes-sigs#579 inadvertently broke the examples/kind/README.md instructions. Note that the static konnectivity-server.yaml and konnectivity-agent.ds.yaml are re-used (by 1. manual getting started instructions, which pulls the latest published images, and 2. Github Action tests at .github/workflows/e2e.yaml).
kubernetes-sigs#579 inadvertently broke the examples/kind/README.md instructions. Note that the static konnectivity-server.yaml and konnectivity-agent.ds.yaml are re-used (by 1. manual getting started instructions, which pulls the latest published images, and 2. Github Action tests at .github/workflows/e2e.yaml).
Continue supporting ARCH env for backward compat, but introduce {BUILDARCH, TARGETARCH}.
This is a big speedup, compared to qemu. On my 10y old machine,
make docker-build-all
took less than 5m. For comparison, see historical latency (source: #274):At #572 we already changed the dockerfiles (support GO_TOOLCHAIN and GO_VERSION). It would be nice to group this additional change together (add to release-0.30).