bug: fix string float conversion #980
Conversation
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mowangdk
force-pushed
the
feature/fix_loopdevice_percent
branch
from
b3502af to
f35172a
Compare
| @@ -158,8 +158,9 @@ func getLoopDeviceCapacity() []*StorageCapacity { | |||
| } | |||
| percent := 0.9 | |||
| if types.GlobalConfigVar.LocalSparseTotalAvailablePercent != "" { | |||
| p, _ := strconv.Atoi(types.GlobalConfigVar.LocalSparseTotalAvailablePercent) | |||
| percent = float64(p) | |||
| if p, err := strconv.ParseFloat(types.GlobalConfigVar.LocalSparseTotalAvailablePercent, 32); err == nil && p < 1 { | |||
There was a problem hiding this comment.
Since this variable is named "Percent", I would not expect it to be less than 1.
Also, for sparse files, over 100% should also be acceptable?
There was a problem hiding this comment.
It's just the space available in a directory, not the sparse-file specific.
There was a problem hiding this comment.
"percent" means 1/100, which is different from implementation. Should we fix this? Either change the semantic or the name of this env to avoid confusions.
mowangdk
force-pushed
the
feature/fix_loopdevice_percent
branch
from
f35172a to
3502e1f
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix float64 conversion
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: