Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store disk type and performance level as slice #878

Merged
merged 2 commits into from
Jan 15, 2024
Merged

store disk type and performance level as slice #878

merged 2 commits into from
Jan 15, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Oct 3, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Avoid repeated split and join.

Which issue(s) this PR fixes:

The original validateDiskPerformaceLevel does not validate the input if it does not contains comma. Fixed this.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mowangdk October 3, 2023 13:39
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2023
@huww98 huww98 force-pushed the disk-type-as-slice branch from 3faf99f to d91820b Compare October 23, 2023 14:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@huww98 huww98 force-pushed the disk-type-as-slice branch from d91820b to f4917b6 Compare November 17, 2023 10:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@huww98
remove struct field tags from diskVolumeArgs
9e806c0 
It is not ever used for json marshal
@huww98 huww98 force-pushed the disk-type-as-slice branch from f4917b6 to c49f3f3 Compare January 9, 2024 14:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
mowangdk
mowangdk reviewed Jan 10, 2024
View reviewed changes
pkg/disk/utils.go
performanceLevel = strings.Split(pl, ",")
for _, cusPer := range performanceLevel {
if _, ok := CustomDiskPerfermance[cusPer]; !ok {
return nil, fmt.Errorf("illegal performance level type: %s", cusPer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return default value []string{} instead of nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of []string is nil.

@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2024
@huww98
store disk type and performance level as slice
d6800b5 
Avoid repeated split and join.

The original validateDiskPerformaceLevel does not validate the input if it does not contains comma. Fixed this.
@huww98 huww98 force-pushed the disk-type-as-slice branch from c49f3f3 to d6800b5 Compare January 10, 2024 04:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@mowangdk
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2024
@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4c27ce4 into kubernetes-sigs:master Jan 15, 2024
7 checks passed
@huww98 huww98 deleted the disk-type-as-slice branch January 29, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowangdk mowangdk mowangdk left review comments

Assignees

@mowangdk mowangdk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huww98 @k8s-ci-robot @mowangdk