Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk: control the degree of concurrency of attach/detach #1216

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Nov 17, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Only 5 concurrent detach is allowed by ECS. So limit that at our side to avoid too many conflicts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

if DiskParallelAttach/DiskParallelDetach feature gates are enabled, the concurrency of attach/detach operations are still limited, defaulting to 32/5, which should match the current ECS limitation.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Only 5 concurrent detach is allowed by ECS. So limit that at our side to avoid too many conflicts.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2024
@mowangdk
Copy link
Contributor

mowangdk commented Nov 25, 2024

/lgtm
/approve

Simultaneous volume attachment and detachment may conflict, we can ignore it as we don't open concurrency detach/attach by default. required more investigation

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit e3f9321 into kubernetes-sigs:master Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants