Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oss: ossfs bump to 1.91.4 and support OSS signature v4 #1180

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

AlbeeSo
Copy link
Member

@AlbeeSo AlbeeSo commented Oct 9, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

cleanup: merge options parsing functions for provisioner and plugin
core: bump ossfs version to 1.91.4.ack.1
feat: support signature v4, which is necessary for special regions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

@AlbeeSo: The label(s) kind/featuew cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/kind featuew

What this PR does / why we need it:

cleanup: merge options parsing functions for provisioner and plugin
core: bump ossfs version to 1.91.4.ack.1
feat: support signature v4, which is necessary for special regions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 9, 2024
@AlbeeSo AlbeeSo force-pushed the feat/ossfs-1.91.4-sigv4 branch from 2797e69 to 4af8c0f Compare October 9, 2024 13:23
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2024
@AlbeeSo AlbeeSo force-pushed the feat/ossfs-1.91.4-sigv4 branch from 4af8c0f to ded4c50 Compare October 11, 2024 05:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2024
@AlbeeSo AlbeeSo force-pushed the feat/ossfs-1.91.4-sigv4 branch from ded4c50 to fe10c89 Compare October 12, 2024 09:26
@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlbeeSo, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2bd02bb into kubernetes-sigs:master Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants