Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk: skip read xattr for files other than block device #1130

Merged

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Aug 6, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

should reduce false warnings about unable to read xattr

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

time="2024-08-06T20:34:04+08:00" level=warning msg="getVolumeCount: failed to get xattr of core, assuming not managed by us: operation not supported"
time="2024-08-06T20:34:04+08:00" level=warning msg="getVolumeCount: failed to get xattr of fd, assuming not managed by us: operation not supported"
time="2024-08-06T20:34:04+08:00" level=warning msg="getVolumeCount: failed to get xattr of initctl, assuming not managed by us: no such file or directory"
time="2024-08-06T20:34:04+08:00" level=warning msg="getVolumeCount: failed to get xattr of log, assuming not managed by us: no such file or directory"
time="2024-08-06T20:34:04+08:00" level=warning msg="getVolumeCount: failed to get xattr of stderr, assuming not managed by us: operation not supported"
time="2024-08-06T20:34:04+08:00" level=warning msg="getVolumeCount: failed to get xattr of stdout, assuming not managed by us: operation not supported"

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


should reduce false warnings about unable to read xattr
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@mowangdk
Copy link
Contributor

mowangdk commented Aug 7, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit fcd51a7 into kubernetes-sigs:master Aug 7, 2024
9 checks passed
@huww98 huww98 deleted the disk-xattr-skip-non-block branch November 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants