disk: refactor create disk #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
|
I will try to add unit test later |
huww98
force-pushed
the
disk-create-refactor
branch
3 times, most recently
from
dd89342 to
b9fed08
Compare
k8s-ci-robot
added
size/XXL
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Because it is also indistinguishable from DescribeDisks.
We will not forget something when adding new category.
Use hash of diskName as client token to ensure only one disk is created for one PVC. If we see IdempotentParameterMismatch, fall back to DescribeDisks to fetch existing disk. When CreateDisk fails, it records the client token only for some case, but we don't know which. If we use a new token for retry, we are risking creating duplicated disks. If we reuse the same token. the retry may fail for IdempotentParameterMismatch. So fetching the existing disk and checking it ourselves seems to be the only choice.
This protection is fragile, it cannot suvive CSI restart, and breaks the detection of inconsistent create parameters between two requests with the same name.
huww98
force-pushed
the
disk-create-refactor
branch
from
b9fed08 to
6993a6c
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
disk: aggregate category metadata into one file
We will not forget something when adding new category.
disk: refactor create disk
Use hash of diskName as client token to ensure only one disk is created for one PVC.
If we see IdempotentParameterMismatch, fall back to DescribeDisks to fetch existing disk.
When CreateDisk fails, it records the client token only for some case, but we don't know which.
If we use a new token for retry, we are risking creating duplicated disks.
If we reuse the same token. the retry may fail for IdempotentParameterMismatch.
So fetching the existing disk and checking it ourselves seems to be the only choice.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Replaces #876
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: