disk: fix partition detection #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/L
Do not rely on the device path to determine partition. Read sysfs instead. Fixes CSI sanity failure: Volume d-2ze2vto7mqwoffxi2uh9 GetDeviceRootAndIndex with error Device /dev/disk/by-id/virtio-2ze2vto7mqwoffxi2uh9 has error format more than one digit locations Fixes: 9a71d43
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Do not rely on the device path to determine partition. Read sysfs instead.
Which issue(s) this PR fixes:
Fixes CSI sanity failure:
Volume d-2ze2vto7mqwoffxi2uh9 GetDeviceRootAndIndex with error Device /dev/disk/by-id/virtio-2ze2vto7mqwoffxi2uh9 has error format more than one digit locations
Fixes: 9a71d43
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: