Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: remove plain nonecs yaml #1034

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Apr 22, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

should be replaced by helm with values-nonecs.yaml

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

deploy/nonecs is replaced by the new helm chart with values-nonecs.yaml

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mowangdk April 22, 2024 03:36
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 22, 2024
should be replaced by helm with values-nonecs.yaml
@mowangdk
Copy link
Contributor

@huww98 please add non-ecs type user document

@huww98 huww98 force-pushed the rm-deploy-nonecs branch from f67fc5c to 3c8a668 Compare April 24, 2024 08:03
@huww98
Copy link
Contributor Author

huww98 commented Apr 24, 2024

@huww98 please add non-ecs type user document

Added a new docs/install.md, and removed some outdated docs.

@huww98 huww98 force-pushed the rm-deploy-nonecs branch from 3c8a668 to 7a2ad08 Compare April 24, 2024 08:10
@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4ea8192 into kubernetes-sigs:master Apr 25, 2024
6 checks passed
@huww98 huww98 deleted the rm-deploy-nonecs branch April 26, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants