Skip to content
This repository has been archived by the owner on Oct 16, 2018. It is now read-only.

Translate tutorials/kubernetes-basics/update in Korean #34

Closed
wants to merge 16 commits into from

Conversation

zer0big
Copy link
Contributor

@zer0big zer0big commented Sep 10, 2018

ianychoi님께서 가이드 주신대로 브랜치를 새로 따서 PR 드려봅니다. 제대로 한건지 모르겠네요..
/assign gochist

zer0big and others added 16 commits August 27, 2018 23:15
kubernetes-basics-expose 한글화
1. content/ko/docs/home/expose-interactive.html
2. content/ko/docs/home/expose-intro.html
2. 불필요한 조사 (을/를) 제거
3. 불필요한 복수 -> 단수 표기
4. 불필요 2인칭 표현 생략
tutorial-kubernetes-basics-update에 대한 한글 번역본 초안입니다.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2018
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gochist

If they are not already assigned, you can assign the PR to them by writing /assign @gochist in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gochist
Copy link
Contributor

gochist commented Sep 10, 2018

@zer0big
Feature Branch(k-basic_update)에서 작업해주셨네요! 👍

그런데 그 Feature Branch가 현재 워킹 브랜치인 kubernetes/kubernetes-docs-ko:dev-1.12에서 분기되지 않고 zer0big/kubernetes-docs-ko:dev-1.12에서 분기되어서 결과적으로 본 PR에 16개의 커밋이 들어왔고 이미 처리 된 #26 의 히스토리가 중복된 커밋으로 포함되어 있고, 처리 중인 #27 의 변경 히스토리도 포함되어있습니다.

예를 들어 origin 리모트가 다음과 같이 설정되어 있다면,

origin	https://github.com/kubernetes/kubernetes-docs-ko (fetch)
origin	https://github.com/kubernetes/kubernetes-docs-ko (push)
zer0big	https://github.com/zer0big/kubernetes-docs-ko (fetch)
zer0big	https://github.com/zer0big/kubernetes-docs-ko (push)

다음과 같이 작업해주시면 update에 관련한 변경만 포함된 PR을 보내실 수 있습니다.

git fetch origin
# 원격 저장소의 dev-1.12 브랜치에서 k-basic-update-2 브랜치 체크아웃하기
git checkout origin/dev-1.12 -b k-basic-update-2
# "[20180910] k-basic-update 한글 번역본" 커밋만 가져오기
git cherry-pick 42959be 
git push zer0big k-basic-update-2

@zer0big
Copy link
Contributor Author

zer0big commented Sep 11, 2018

@gochist 가이드 감사드립니다. 다시 PR 드렸습니다.

@gochist
Copy link
Contributor

gochist commented Sep 11, 2018

본 PR은 여기서 닫고 #35 로 처리하겠습니다.
/close

@k8s-ci-robot
Copy link

@gochist: Closing this PR.

In response to this:

본 PR은 여기서 닫고 #35 로 처리하겠습니다.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zer0big zer0big deleted the k-basic_update branch September 11, 2018 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants