-
Notifications
You must be signed in to change notification settings - Fork 532
Make kubefed webhook replica count configurable #1469
Make kubefed webhook replica count configurable #1469
Conversation
So it can be Highly Available (HA) Added in description to the README.md Bumped up the chart version of the controller manager Bumped up the dependency version
@xunpan @makkes , Do you know how to update the helm charts to reflect these new changes? When the charts gets pulled remotely they still have the old charts and not the new updated ones? Does a new tag need to be created, 0.8.2? |
/assign @jimmidyson |
/retest |
@nitinatgh: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can someone take a look at this PR for approval please? |
/lgtm |
/ok-to-test |
/retest |
1 similar comment
/retest |
@nitinatgh Was going through pending issues and PRs and noticed this. Can you please rebase this. I think the unrelated test failure has been fixed by #1500 |
@irfanurrehman @makkes |
Thanks @nitinatgh for doing this |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, makkes, nitinatgh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
So it can be Highly Available (HA)
Added in description to the README.md
Bumped up the chart version of the controller manager
Bumped up the dependency version
What this PR does / why we need it: This PR gives the users an option to set the number of replicas for the Kubefed Admission Webhook
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1456
Special notes for your reviewer:
Tested it out as follows in a local kind cluster
helm upgrade dry-run
helm upgrade