Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Make kubefed webhook replica count configurable #1469

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

nitinatgh
Copy link
Contributor

So it can be Highly Available (HA)
Added in description to the README.md
Bumped up the chart version of the controller manager
Bumped up the dependency version

What this PR does / why we need it: This PR gives the users an option to set the number of replicas for the Kubefed Admission Webhook

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1456

Special notes for your reviewer:
Tested it out as follows in a local kind cluster

$ kubectl get pods -A
NAMESPACE                NAME                                             READY   STATUS    RESTARTS   AGE
...
kube-federation-system   kubefed-admission-webhook-67fb48d5f7-kw4ps       1/1     Running   0          4d17h
...

helm upgrade dry-run

$ helm --namespace kube-federation-system upgrade -i kubefed ./kubefed --create-namespace --dry-run
...
# Source: kubefed/charts/controllermanager/templates/deployments.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  namespace: kube-federation-system
  name: kubefed-admission-webhook
  labels:
    kubefed-admission-webhook: "true"
spec:
  replicas: 2
  selector:
    matchLabels:
...

helm upgrade

$ helm --namespace kube-federation-system upgrade -i kubefed ./kubefed --create-namespace
Release "kubefed" has been upgraded. Happy Helming!
NAME: kubefed
LAST DEPLOYED: Tue Sep 14 10:33:35 2021
NAMESPACE: kube-federation-system
STATUS: deployed
REVISION: 13
TEST SUITE: None

$ kubectl get pods -A
NAMESPACE                NAME                                             READY   STATUS    RESTARTS   AGE
...
kube-federation-system   kubefed-admission-webhook-67fb48d5f7-kw4ps       1/1     Running   0          4d17h
kube-federation-system   kubefed-admission-webhook-67fb48d5f7-r4vf5       1/1     Running   0          93s
...

So it can be Highly Available (HA)
Added in description to the README.md
Bumped up the chart version of the controller manager
Bumped up the dependency version
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2021
@nitinatgh
Copy link
Contributor Author

/assign @xunpan
/assign @makkes

@nitinatgh
Copy link
Contributor Author

@xunpan @makkes , Do you know how to update the helm charts to reflect these new changes? When the charts gets pulled remotely they still have the old charts and not the new updated ones? Does a new tag need to be created, 0.8.2?
Any help on this would be great as we'd like to start using the charts with the latest updates in our clusters please.
Thanks!

@nitinatgh
Copy link
Contributor Author

/assign @jimmidyson

@nitinatgh
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@nitinatgh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nitinatgh
Copy link
Contributor Author

Can someone take a look at this PR for approval please?
@jimmidyson @xunpan @makkes
Thanks!

@makkes
Copy link
Contributor

makkes commented Jan 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@makkes
Copy link
Contributor

makkes commented Jan 7, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 7, 2022
@makkes
Copy link
Contributor

makkes commented Jan 7, 2022

/retest

1 similar comment
@nitinatgh
Copy link
Contributor Author

/retest

@irfanurrehman
Copy link
Contributor

@nitinatgh Was going through pending issues and PRs and noticed this. Can you please rebase this. I think the unrelated test failure has been fixed by #1500

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2022
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 22, 2022
@nitinatgh
Copy link
Contributor Author

@irfanurrehman @makkes
Have updated with master and tests seems to be passing, so looks all good to go I hope?
Thanks!

@irfanurrehman
Copy link
Contributor

Thanks @nitinatgh for doing this
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irfanurrehman, makkes, nitinatgh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4babb44 into kubernetes-retired:master Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Kubefed Admission Webhook replica count configurable for High Availability
6 participants