Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Tweaks to network config #1408

Merged

Conversation

cknowles
Copy link
Contributor

Fixes #1407.

For now just document the podCIDR aspects but we should probably switch the default based on the networking setup, possibly combine this config with the selfHosting config into a networking section.

Fixes kubernetes-retired#1407.

For now just document the `podCIDR` aspects but we should probably switch the default based on the networking setup, possibly combine this config with the `selfHosting` config into a networking section.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2018
@cknowles
Copy link
Contributor Author

@davidmccormick I cannot assign you for review but worth a look.

@cknowles cknowles requested a review from mumoshu July 15, 2018 06:30
@codecov-io
Copy link

codecov-io commented Jul 15, 2018

Codecov Report

Merging #1408 into master will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1408      +/-   ##
==========================================
+ Coverage   37.53%   38.26%   +0.73%     
==========================================
  Files          74       74              
  Lines        4534     4565      +31     
==========================================
+ Hits         1702     1747      +45     
+ Misses       2597     2576      -21     
- Partials      235      242       +7
Impacted Files Coverage Δ
model/node_pool_config.go 20.58% <0%> (ø) ⬆️
model/custom_file.go 64.51% <0%> (ø) ⬆️
model/iamconfig.go 0% <0%> (ø) ⬆️
cfnstack/provisioner.go 0% <0%> (ø) ⬆️
core/controlplane/config/config.go 63.62% <0%> (+0.04%) ⬆️
core/controlplane/cluster/cluster.go 50% <0%> (+0.69%) ⬆️
core/nodepool/cluster/cluster.go 46.51% <0%> (+1.27%) ⬆️
model/etcd_cluster.go 26.31% <0%> (+26.31%) ⬆️
model/etcd.go 34.02% <0%> (+34.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c43b5...b63a183. Read the comment docs.

@cknowles
Copy link
Contributor Author

@mumoshu please hold off on merging this, something is causing nodes in a couple of our clusters to shift into SchedulingDisabled status a bit at random and not yet sure if it's this change or the one in #1397. I believe it to be this change because we've been running the other PR in two clusters for a week without issue and it seems to only be when we rolled this change that nodes starting becoming randomly unhealthy. Note, this is even with a totally fresh stack (as we did change the pod CIDR change so wanted a fresh one).

@cknowles
Copy link
Contributor Author

cknowles commented Sep 4, 2018

@mumoshu I believe we identified the cause of my noted issues above as unrelated now. I've corrected my cluster.yaml notes according to @davidmccormick's feedback in #1407. I think this is ready to merge.

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for sharing your hard-won insights 🙏

@mumoshu mumoshu merged commit 52fb54c into kubernetes-retired:master Sep 16, 2018
@mumoshu mumoshu added this to the v0.11.0 milestone Sep 16, 2018
@cknowles cknowles deleted the chore/network-config-tweaks branch December 5, 2018 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants