-
Notifications
You must be signed in to change notification settings - Fork 294
Tweaks to network config #1408
Tweaks to network config #1408
Conversation
Fixes kubernetes-retired#1407. For now just document the `podCIDR` aspects but we should probably switch the default based on the networking setup, possibly combine this config with the `selfHosting` config into a networking section.
@davidmccormick I cannot assign you for review but worth a look. |
Codecov Report
@@ Coverage Diff @@
## master #1408 +/- ##
==========================================
+ Coverage 37.53% 38.26% +0.73%
==========================================
Files 74 74
Lines 4534 4565 +31
==========================================
+ Hits 1702 1747 +45
+ Misses 2597 2576 -21
- Partials 235 242 +7
Continue to review full report at Codecov.
|
@mumoshu please hold off on merging this, something is causing nodes in a couple of our clusters to shift into |
@mumoshu I believe we identified the cause of my noted issues above as unrelated now. I've corrected my cluster.yaml notes according to @davidmccormick's feedback in #1407. I think this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much for sharing your hard-won insights 🙏
Fixes #1407.
For now just document the
podCIDR
aspects but we should probably switch the default based on the networking setup, possibly combine this config with theselfHosting
config into a networking section.