Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Bug/flannel cni binary install #1235

Merged

Conversation

davidmccormick
Copy link
Contributor

@davidmccormick davidmccormick commented Apr 11, 2018

Apologies! Here's a fix for legacy flannel missing cni binaries bug introduced by pull request #1195

Fixes issue - #1232

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #1235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   36.56%   36.56%           
=======================================
  Files          63       63           
  Lines        3878     3878           
=======================================
  Hits         1418     1418           
  Misses       2242     2242           
  Partials      218      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87aa5a9...4663f4f. Read the comment docs.

@ktateish
Copy link
Contributor

I confirmed pods in the clusters created with this branch can come up properly. Thanks!

$ kubectl get pods --all-namespaces
NAMESPACE     NAME                                                READY     STATUS    RESTARTS   AGE
kube-system   heapster-7f977f75f7-jkjr4                           2/2       Running   0          5m
kube-system   kube-apiserver-ip-10-0-0-94.ec2.internal            1/1       Running   0          10m
kube-system   kube-controller-manager-ip-10-0-0-94.ec2.internal   1/1       Running   0          10m
kube-system   kube-dns-autoscaler-c895d6bbd-vjjq6                 1/1       Running   0          11m
kube-system   kube-dns-d87fdd65-96mnt                             3/3       Running   0          11m
kube-system   kube-dns-d87fdd65-fchdc                             3/3       Running   0          5m
kube-system   kube-proxy-ldswh                                    1/1       Running   0          11m
kube-system   kube-proxy-xjvkl                                    1/1       Running   0          5m
kube-system   kube-scheduler-ip-10-0-0-94.ec2.internal            1/1       Running   0          10m
kube-system   kubernetes-dashboard-6ff488bcdd-ddsjq               1/1       Running   0          11m
kube-system   tiller-deploy-54df45d89c-6trs6                      1/1       Running   0          11m

@mumoshu mumoshu merged commit 137aa37 into kubernetes-retired:master Apr 12, 2018
@mumoshu
Copy link
Contributor

mumoshu commented Apr 12, 2018

LGTM. Thanks everyone for your supports ☺️

@mumoshu mumoshu added this to the v0.9.10-rc.2 milestone Apr 12, 2018
@davidmccormick davidmccormick deleted the bug/flannel-cni-binary-install branch January 2, 2019 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants