Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

kube-aws should warn or fail when it sees unexpected keys in cluster.yaml #404

Closed
mumoshu opened this issue Mar 10, 2017 · 2 comments
Closed

kube-aws should warn or fail when it sees unexpected keys in cluster.yaml #404

mumoshu opened this issue Mar 10, 2017 · 2 comments
Labels
priority/P2
Milestone
v0.9.5-rc.5

Comments

@mumoshu
Copy link
Contributor

mumoshu commented Mar 10, 2017

cc @redbaron I believe you've mentioned about this feature in a comment somewhere but I'm not sure where it was!
@mumoshu
Copy link
Contributor Author

mumoshu commented Mar 10, 2017

I believe that our users tend to have troubles writing cluster.yaml correctly these days.
It is even more problematic when there's typo in a comment in cluster.yaml like #392

@mumoshu
Copy link
Contributor Author

mumoshu commented Mar 10, 2017

@c-knowles I believe you've asked about how it achieve this before?
Perhaps something like below works to instruct go-yaml to catch unexpected keys, according to its documentation.

unexpectedSettings map[string]interface{} `yaml:",inline"`

@mumoshu mumoshu added this to the v0.9.5 milestone Mar 10, 2017
@mumoshu mumoshu mentioned this issue Mar 10, 2017
Closed
@mumoshu mumoshu changed the title Make kube-aws warn or fail when it sees unexpected keys in cluster.yaml kube-aws should warn or fail when it sees unexpected keys in cluster.yaml Mar 10, 2017
@mumoshu mumoshu modified the milestones: v0.9.5-rc.5, v0.9.5 Mar 20, 2017
@mumoshu mumoshu mentioned this issue Mar 21, 2017
Merged
mumoshu added a commit to mumoshu/kube-aws that referenced this issue Mar 21, 2017
@mumoshu
Emit errors when kube-aws sees unexpected keys in cluster.yaml
86380e0 
Resolves kubernetes-retired#404
camilb added a commit to camilb/kube-aws that referenced this issue Apr 5, 2017
@camilb
Merge remote-tracking branch 'kubernetes-incubator/master'
7f93c09 
* kubernetes-incubator/master: (29 commits)
  Emit errors when kube-aws sees unexpected keys in cluster.yaml Resolves kubernetes-retired#404
  Tag controller nodes appropriately with `kubernetes.io/role`. Resolves kubernetes-retired#370
  Make Container Linux AMI fetching a bit more reliable
  Stop locksmithd errors on etcd nodes
  Upgrade heapster to version 1.3.0 (kubernetes-retired#420)
  Auth token file support (kubernetes-retired#418)
  Update README.md
  Update README accordingly to the new git repo
  AWS China region support (kubernetes-retired#390)
  Conform as a Kubernetes Incubator Project
  Fixed typo in template
  upgrade aws-sdk to latest version Fix kubernetes-retired#388
  Upgrade Kubernetes version to v1.5.4
  Fix assumed public hostnames for EC2 instances in us-east-1
  Fix assumed public hostnames for EC2 instances in us-east-1
  typo
  fix: etcdDataVolumeEncrypted not creating encrypted volumes fixes kubernetes-retired#383
  Allow disabling wait signals fixes kubernetes-retired#371
  Update file paths in readme
  Fix an issue with glue security group documentation
  ...
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this issue Mar 27, 2018
@mumoshu
Emit errors when kube-aws sees unexpected keys in cluster.yaml
2229306 
Resolves kubernetes-retired#404
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority/P2
Projects
None yet
Milestone
v0.9.5-rc.5
Development

No branches or pull requests
1 participant
@mumoshu