Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Add packages required for systemd mounts #213

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

hakman
Copy link
Contributor

@hakman hakman commented Apr 29, 2021

For this to actually work, /run needs to be mounted inside the pod on kOps side, otherwise it does nothing.
xRef: https://github.com/kubernetes/mount-utils/blob/19c6fae41ad49f3e4026f28b043f41343aa852fd/mount_linux.go#L145-L166

Before:

I0429 04:57:20.495826    9315 mount_linux.go:192] Detected OS without systemd
I0429 04:57:20.497333    9315 mounter.go:241] matched device "/dev/nvme2n1" and "/dev/nvme2n1" via '\x00'
I0429 04:57:20.497364    9315 mounter.go:94] mounted master volume "vol-02aa61026842d90dd" on /mnt/master-vol-02aa61026842d90dd

After:

I0429 06:42:24.481969   51116 mount_linux.go:206] Detected OS with systemd
I0429 06:42:24.485360   51116 mounter.go:241] matched device "/dev/nvme2n1" and "/dev/nvme2n1" via '\x00'
I0429 06:42:24.485393   51116 mounter.go:94] mounted master volume "vol-02aa61026842d90dd" on /mnt/master-vol-02aa61026842d90dd

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot requested a review from olemarkus April 29, 2021 07:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olemarkus
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4703d50 into kubernetes-retired:master Apr 29, 2021
@hakman hakman deleted the systemd-mounts branch April 29, 2021 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants