Fix recording events

[kvaps]

There is an issue with writing events in different namespaces: kubernetes-retired/container-object-storage-interface-provisioner-sidecar#140

This happens because events are created with a specified namespace, and the EventRecorder also has a namespace option set.

This PR removes the namespace option from the EventRecorder so events can be created in namespace they have specifyed.

Similar change can be found in this project
tsuru/remesher@a8ccfa0#diff-243ebed2765f75e6a54f57167212fefb08c3b2a85967ad2acbc0eb78919019c1

[BlaineEXE]

@kvaps could you please add more description to the commit and github description? What are the symptoms of the issue, and how does this PR fix the issue?

[update] I see after looking at your other PR that this is a fix for kubernetes-retired/container-object-storage-interface-provisioner-sidecar#140.

[BlaineEXE]

@kvaps we really appreciate your contribution. There is a complication that makes this challenging right now. We are in the process of migrating from separate API/spec/controller/sidecar repos into a monorepo at https://github.com/kubernetes-sigs/container-object-storage-interface-api. We are still working on merging the controller into the monorepo, and the sidecar will come after that.

In the interest of ensuring your contribution gets recorded, I will propose this:

Could you change the merge target from kubernetes-sigs:master to kubernetes-sigs:monrepo (the monorepo branch)? We can then merge this, and the inclusion of the change will be handled once we finish moving the controller/controller.go code into its new location where it will be a better-named basis for shared code between controller and sidecar.

[kvaps]

sure PR rebased

[BlaineEXE]

Also requesting @shanduur 's review since he worked on adding event recording

[shanduur]

Ah, right! Must have missed that bit, thanks!

[shanduur]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvaps, shanduur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shanduur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BlaineEXE]

/lgtm