-
Notifications
You must be signed in to change notification settings - Fork 218
update Kubernetes dependencies to 1.9.3 #895
update Kubernetes dependencies to 1.9.3 #895
Conversation
|
||
[[override]] | ||
name = "cloud.google.com/go" | ||
revision = "3b1ae45394a234c385be014e9a488f2bb6eef821" | ||
[[override]] | ||
name = "github.com/aws/aws-sdk-go" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl imports the aws sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently :(
[[override]] | ||
name = "github.com/docker/go-connections" | ||
revision = "f549a9393d05688dff0992ef3efd8bbe6c628aeb" | ||
[[override]] | ||
name = "github.com/docker/go-units" | ||
revision = "e30f1e79f3cd72542f2026ceec18d3bd67ab859c" | ||
[[override]] | ||
name = "github.com/docker/spdystream" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all of these other changes transitive dependenices? Or did all other deps get bumped up too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All transitive dependencies. I've explicitly listed them because dep doesn't parse godep and glide files in other repos. It won't automatically detect the versions the kubernetes requests.
Thanks for satisfying my curiosity. Approved, assuming e2e passes, etc. |
|
Oh wait, this is my bad
|
coreosbot run e2e |
This is becoming a mess. Going to try to address #442 instead. |
We badly need to stop importing kubectl. It's much less regimented about what we import and is really bloating our transitive dependencies.
closes #833
cc @rphillips @colemickens