Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

templates: increase API server verbosity #831

Closed
wants to merge 2 commits into from
Closed

templates: increase API server verbosity #831

wants to merge 2 commits into from

Conversation

ericchiang
Copy link
Contributor

@ericchiang ericchiang commented Jan 12, 2018

This PR is intended to help debug our e2e test flakes #824. It's not intended to be merged.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2018
@ericchiang ericchiang added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 12, 2018
@xiang90
Copy link
Contributor

xiang90 commented Jan 12, 2018

maybe our e2e test should always start the API server with v6?

@ericchiang
Copy link
Contributor Author

@xiang90 yeah but I don't think the audit changes are appropriate for everyone. Would require a knob.

@xiang90
Copy link
Contributor

xiang90 commented Jan 12, 2018

@xiang90 yeah but I don't think the audit changes are appropriate for everyone.

agree

Would require a knob.

i hate to add the knob just for testing in general. we probably can figure out something better. one ugly approach is to add it in testing scripts after running bootkube render.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2018
@ericchiang
Copy link
Contributor Author

Found #837

Closing for now.

@ericchiang ericchiang closed this Jan 22, 2018
@ericchiang ericchiang deleted the apiserver-verbosity branch January 22, 2018 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants