This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Update kube-dns and switch sidecar to probe SRV records #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dghubble
commented
Jan 12, 2018
dghubble
commented
- Update kube-dns from v1.14.5 to v1.14.8
- Switch kube-dns sidecar to probe for SRV records (recommended for 1.9)
- addons/dns: changing probes for ANY IP record type kubernetes/kubernetes#51378
k8s-ci-robot
added
cncf-cla: yes
rphillips
approved these changes
Jan 12, 2018
|
Jenkins was down, re-running tests. |
|
coreosbot run e2e |
colemickens
approved these changes
Jan 12, 2018
|
coreosbot run e2e calico |
|
coreosbot run e2e |
|
This is plagued by the same TestSmoke flake. |
|
I've seen both e2e and e2e-calico succeed on independent runs, but yeah, its the TestSmoke flake. |
|
I suggest us to get PR merged if they are blocked by any known flake, and we believe this PR wont make the flake more serious. |
|
Same failure we saw in #828 (comment), that's not good. |
|
Gah, forgot to merge this :( |
|
coreosbot run e2e |
|
Passed tests, but rebasing to the history is cleaner. |
|
coreosbot run e2e |
* Recommended for Kubernetes 1.9 * kubernetes/kubernetes#51378
|
coreosbot run e2e |
1 similar comment
|
coreosbot run e2e |
|
@dghubble tests are green. feel free to merge |
|
Finally! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.