This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
checkpointer: bump default checkpointer version. #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
ericchiang
reviewed
Jan 8, 2018
e2e/checkpointer_test.go
Outdated
| @@ -448,6 +448,7 @@ spec: | |||
| image: %s | |||
| command: | |||
| - /checkpoint | |||
| - --checkpoint-grace-period=5s | |||
Also use new flag (in this checkpointer version) to vastly shorten the grace period in the checkpoint tests.
rphillips
approved these changes
Jan 8, 2018
e2e/checkpointer_test.go
Outdated
| @@ -448,6 +448,7 @@ spec: | |||
| image: %s | |||
| command: | |||
| - /checkpoint | |||
| - --checkpoint-grace-period=5s | |||
|
/lgtm assuming the tests pass |
|
coreosbot run e2e |
|
Flake I think, ref #824 |
|
coreosbot run e2e |
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Feb 15, 2018
* No notable changes except a grace period flag we don't use * kubernetes-retired/bootkube#826
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use new flag (in this checkpointer version) to vastly shorten the
grace period in the checkpoint tests.