This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
templates: enable etcd-quorum-read in apiserver #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
@hongchaodeng can you also set it on the bootstrap apiserver? |
|
Then as a follow-up this should be done in tectonic-installer too: https://github.com/coreos/tectonic-installer/blob/master/modules/bootkube/resources/bootstrap-manifests/bootstrap-apiserver.yaml |
hongchaodeng
force-pushed
the
hongchaodeng-patch-2-1
branch
from
d1b54a2 to
db8090e
Compare
|
added to bootstrap apiserver |
diegs
approved these changes
Jul 18, 2017
pkg/asset/internal/templates.go
Outdated
| @@ -175,6 +175,7 @@ spec: | |||
| - --etcd-keyfile=/etc/kubernetes/secrets/etcd-client.key | |||
| {{- end }} | |||
| - --etcd-servers={{ range $i, $e := .EtcdServers }}{{ if $i }},{{end}}{{ $e }}{{end}} | |||
| - --etcd-quorum-read=true | |||
There was a problem hiding this comment.
nit: quorum comes before servers
pkg/asset/internal/templates.go
Outdated
| @@ -251,6 +252,7 @@ spec: | |||
| - --etcd-keyfile=/etc/kubernetes/secrets/etcd-client.key | |||
| {{- end }} | |||
| - --etcd-servers={{ range $i, $e := .EtcdServers }}{{ if $i }},{{end}}{{ $e }}{{end}}{{ if .SelfHostedEtcd }},https://127.0.0.1:12379{{end}} | |||
| - --etcd-quorum-read=true | |||
hongchaodeng
force-pushed
the
hongchaodeng-patch-2-1
branch
from
db8090e to
fc83f5e
Compare
|
fixed |
hongchaodeng
force-pushed
the
hongchaodeng-patch-2-1
branch
from
fc83f5e to
ed98d4f
Compare
|
Merging because the tests passed last time and this failure is unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For HA setup, enabling quorum-read is necessary.