This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
pkg/util/etcdutil: improve etcd migration logs #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
hongchaodeng
approved these changes
Apr 28, 2017
pkg/util/etcdutil/migrate.go
Outdated
|
|
||
| if err := waitEtcdClusterRunning(restClient); err != nil { | ||
| return fmt.Errorf("wait etcd cluster running failed: %v", err) | ||
| return fmt.Errorf("failed to wait for etcd cluster to be running: %v", err) |
There was a problem hiding this comment.
"etcd cluster's status"
pkg/util/etcdutil/migrate.go
Outdated
| @@ -158,7 +158,7 @@ func waitEtcdClusterRunning(restclient restclient.Interface) error { | |||
| err := wait.Poll(10*time.Second, waitEtcdClusterRunningTime, func() (bool, error) { | |||
| b, err := restclient.Get().RequestURI(makeEtcdClusterURI(etcdClusterName)).DoRaw() | |||
| if err != nil { | |||
| return false, fmt.Errorf("fail to get etcdcluster: %v", err) | |||
| return false, fmt.Errorf("failed to get etcd cluster: %v", err) | |||
pkg/util/etcdutil/migrate.go
Outdated
| @@ -195,12 +195,12 @@ func waitBootEtcdRemoved(etcdServiceIP string) error { | |||
| cancel() | |||
| etcdcli.Close() | |||
| if err != nil { | |||
| glog.Errorf("fail to list member, will retry: %v", err) | |||
| glog.Errorf("failed to list members, will retry: %v", err) | |||
|
lgtm after addressing the minor issues hongchao pointed out. thanks! |
After running into issues deploying self-hosted etcd on Tectonic, I saw lots of error logs. I thought the logs could be improved and be more consistent.
|
Thanks, @hongchaodeng and @xiang90. I addressed the nits. @yifan-gu or @pbx0 can someone with rights plz merge? |
aaronlevy
approved these changes
Apr 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running into issues deploying self-hosted etcd on Tectonic, I saw
lots of error logs. I thought the logs could be improved and be more
consistent.
cc @hongchaodeng