This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Deploy checkpointer independently from api-server #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlevy
reviewed
Nov 1, 2016
| namespace: kube-system | ||
| labels: | ||
| k8s-app: kube-api-checkpointer | ||
| version: v1.0.0 |
There was a problem hiding this comment.
Can you drop this version label
aaronlevy
reviewed
Nov 1, 2016
| metadata: | ||
| labels: | ||
| k8s-app: kube-api-checkpointer | ||
| version: v1.0.0 |
aaronlevy
reviewed
Nov 1, 2016
| CheckpointerTemplate = []byte(`apiVersion: "extensions/v1beta1" | ||
| kind: DaemonSet | ||
| metadata: | ||
| name: kube-api-checkpointer |
There was a problem hiding this comment.
We may want to name this checkpoint-installer to match what it is actually doing. /cc @derekparker
|
Couple minor comments. Can you also be sure to sign the CLA so that check passes. And also will wait on a review from @derekparker |
kenan435
force-pushed
the
deploy-checkpointer-independently
branch
from
1422844 to
67092cb
Compare
|
Code review findings fixed. Looks like the cla check passed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpointer deployed independently from api-server. Deploying it as a separate component so it can be upgraded independently.
fixes #161