Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: add "WSS" to the memory_usage widget label in grafana #599

Merged
merged 2 commits into from
Apr 22, 2021
Merged

dashboards: add "WSS" to the memory_usage widget label in grafana #599

merged 2 commits into from
Apr 22, 2021

Conversation

Elbehery
Copy link
Contributor

This adds "Working Set" (WSS) to "Memory Usage" widget.

The "Memory Usage" titles should be properly labeled to indicate that they are "Working Set" (WSS), differencing and qualifying them from the RSS, Cache and Swap titles and data.

@sichvoge
Copy link

@Elbehery Can you also add "(WSS)" to the "Memory Usage" panel (see

g.panel('Memory Usage') +
)?

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@paulfantom paulfantom merged commit 71cc61a into kubernetes-monitoring:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants