fix test of ProviderSpecific comparison #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
lgtm |
|
I'm fine with letting this go to make sure that we have a latest release that is stable. /lgtm |
k8s-ci-robot
added
the
lgtm
|
@jhohertz As suspected, here are the conflicts, can you resolve them? |
Signed-off-by: Joe Hohertz <[email protected]>
jhohertz
force-pushed
the
fix-provider-specific-compare
branch
from
65c9578 to
8b1c157
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
docker image available at: registry.opensource.zalan.do/teapot/external-dns:v0.5.10-16-gfe39b46 |
|
v0.5.10-16-gfe39b46 fixed the constant updating problem we were seeing with v0.5.10 on GKE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will fix the "constant updating" issue introduced in 0.5.10 for all providers (#883, #879) except AWS, which will still require something like #880 to be applied, since that is a different comparison problem of properties that exist on one side only.
At issue is that providers not using the new ProviderSpecific mechanism will have endpoints where ProviderSpecific is
<nil>, where the endpoints from sources with no ProviderSpecific elements is instead set to an empty list of that type.This change simply adds a test for the specific test of "provider is nil, source is empty" and returns false.
There may be a better way to fix this impedance mismatch between the two interfaces, but this quick fix should address the majority of problems.
A built container combining this with #880 is available at
viafoura/external-dns:combined-update-fix, and seems to fix the issue. (Though I am only testing AWS provider... which is testing #880 more than this PR....)Signed-off-by: Joe Hohertz [email protected]