Cherry-pick of 108: Update image and tag parameter for Dockerfile.Windows #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile.Windows has two container images, servercore and nanoserver, use seperate parameter for them.
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
k8s-ci-robot
added
size/S
jingxu97
changed the title
|
cc @msau42 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
xing-yang
added a commit
that referenced
this pull request
Nov 19, 2020
c6a88c6e Merge pull request #113 from xing-yang/install_snapshot_controller 45ec4c69 Fix the install of snapshot CRDs and controller 5d874cce Merge pull request #112 from xing-yang/cleanup 79bbca7b Cleanup d4376730 Merge pull request #111 from xing-yang/update_snapshot_v1_rc 57718f83 Update snapshot CRD version git-subtree-dir: release-tools git-subtree-split: c6a88c6ed96b939bd150472b12693252942116c7
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile.Windows has two container images, servercore and nanoserver,
use seperate parameter for them.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: