Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structured logging #228

Closed
jcogilvie opened this issue Oct 13, 2022 · 5 comments · Fixed by #349
Closed

Support structured logging #228

jcogilvie opened this issue Oct 13, 2022 · 5 comments · Fixed by #349
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jcogilvie
Copy link

The node-driver-registrar container should support structured logging when given the --log-format-json flag, like for instance the secrets-store-csi-driver does.

A simple implementation can be found here: https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/cmd/secrets-store-csi-driver/main.go#L90-L94
@mauriciopoppe mauriciopoppe added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 17, 2022
@mauriciopoppe
Copy link
Member

Thanks for the pointer, I was reading how the kubelet does it and it's very similar, on top of this change we need to update the log methods to the suffix S e.g. Infof -> InfoS, etc

References:

@mauriciopoppe mauriciopoppe mentioned this issue Oct 18, 2022
Closed
@mauriciopoppe mauriciopoppe mentioned this issue Nov 9, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@jcogilvie
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@chenliu1993
Copy link

chenliu1993 commented Mar 11, 2023 •
edited
Loading

If that's ok and nobody it is working on this issue, I'd like to take this one

@chenliu1993
Copy link

If that's ok and nobody it is working on this issue, I'd like to take this one

Seems there is already a PR working on this issue, so I am not taking this one

Sneha-at added a commit to Sneha-at/node-driver-registrar that referenced this issue Aug 17, 2023
@Sneha-at
Squashed 'release-tools/' changes from 1df23dba..de2fba88
91c759b 
de2fba88 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1
cee895e1 remove windows 20H2 build since it's EOL long time ago
670bb0ef Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors
35d5e783 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry
63473cc9 Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5
29a5c76c Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels
8dd28211 Update cloudbuild image with go 1.20.5
2b8b80ea fixing some codespell errors
72984ec0 chore: adopt kubernetes recommand label
901bcb5a Update registry k8s.gcr.io -> registry.k8s.io

git-subtree-dir: release-tools
git-subtree-split: de2fba88becec7dec6744355a8ddb0057c5fe2f9
@rlia rlia mentioned this issue Sep 21, 2023
Closed
This was referenced Oct 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
5 participants
@jcogilvie @mauriciopoppe @chenliu1993 @k8s-ci-robot @k8s-triage-robot