Selector in VolumeGroupSnapshotSource API should be optional #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
nixpanic
force-pushed
the
VolumeGroupSnapshot/optional-selector
branch
from
6a5e8f1 to
1d6126c
Compare
k8s-ci-robot
added
size/M
|
/cc xing-yang RaunakShah Please have a look, combined with #837 the VolumeGroupSnapshot feature should be pretty much ready for users to try out. |
nixpanic
force-pushed
the
VolumeGroupSnapshot/optional-selector
branch
from
1d6126c to
e16739e
Compare
xing-yang
reviewed
Jan 26, 2024
nixpanic
force-pushed
the
VolumeGroupSnapshot/optional-selector
branch
from
e16739e to
153a0e7
Compare
nixpanic
force-pushed
the
VolumeGroupSnapshot/optional-selector
branch
from
153a0e7 to
9e58d4c
Compare
RaunakShah
approved these changes
Jan 26, 2024
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, RaunakShah, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
When using a VolumeGroupSnapshotContent for a pre-preprovisioned VolumeGroupSnapshotSource, there is no correct value for the
selectorproperty. However, the original API requires theselectorto be set, even though it is not used.Which issue(s) this PR fixes:
This problem was identified in #837.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: