Requeue un-ready volume snapshots #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
xing-yang
reviewed
Nov 13, 2023
jsafrane
force-pushed
the
fix-unready-requeue
branch
from
ac102fc to
5d5ca97
Compare
xing-yang
reviewed
Nov 15, 2023
|
The Trivy error should be fixed by this PR. Please help merge it. Thanks. |
jsafrane
force-pushed
the
fix-unready-requeue
branch
from
5d5ca97 to
3063863
Compare
|
/retest |
|
I think you need to rebase. |
Tests must fail when syncContent() returns success and error was expected.
SnapshotContents with readyToUse: false should be periodically requeued with exp. backoff until the CSI driver confirms the snapshot is ready.
jsafrane
force-pushed
the
fix-unready-requeue
branch
from
3063863 to
8a29bf5
Compare
|
Rebased |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Requeue a VolumeSnapshotContent that is
readyToUse: falsewith an exp. backoff. This will retry CreateSnapshot CSI call until the snapshot finally getsreadyToUse: true.Which issue(s) this PR fixes:
Fixes #953
Special notes for your reviewer:
I updated the existing unit tests in the first commit to be able to check when
syncContentreturns no error when an error was expected.Does this PR introduce a user-facing change?: