-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more detail in vgs/vgsc/vgsclass printed columns #865
Conversation
Welcome @winrouter! |
Hi @winrouter. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@winrouter please add a release note. LGTM cc @xing-yang /ok-to-test |
thanks for your review @carlory , your comment have been addressed. |
client/config/crd/groupsnapshot.storage.k8s.io_volumegroupsnapshotcontents.yaml
Outdated
Show resolved
Hide resolved
client/config/crd/groupsnapshot.storage.k8s.io_volumegroupsnapshots.yaml
Show resolved
Hide resolved
thanks for you review, I already fixed it. review again @RaunakShah |
/lgtm |
/assign @xing-yang ping @xing-yang for approval |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaunakShah, winrouter, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add more detail printed columns when exec kubectl get vgs | vgsc | vgsclass
before
after
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@xing-yang @RaunakShah
help me check the feature is ok, thanks
Does this PR introduce a user-facing change?: