Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail in vgs/vgsc/vgsclass printed columns #865

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

winrouter
Copy link
Contributor

@winrouter winrouter commented Jun 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add more detail printed columns when exec kubectl get vgs | vgsc | vgsclass

before

[root@node-1 deploy]# kubectl get vgsc
NAME                                                    AGE
groupsnapcontent-03314fd3-faa5-4aea-a14b-416b8b47ba86   4h24m

[root@node-1 deploy]# kubectl get vgs
NAME                AGE
hostpath-mock-vgs   4h24m

[root@node-1 deploy]# kubectl get vgsc
NAME                                                    AGE
groupsnapcontent-03314fd3-faa5-4aea-a14b-416b8b47ba86   4h24m

after

[root@node-1 new-crd]# kubectl get vgsclass
NAME                 DRIVER                DELETIONPOLICY   AGE
hostpath-mock-vgsc   hostpath.csi.ake.io   Delete           4d6h


[root@node-1 new-crd]# kubectl get vgs
NAME                READYTOUSE   VOLUMEGROUPSNAPSHOTCLASS   VOLUMEGROUPSNAPSHOTCONTENT                              CREATIONTIME   AGE
hostpath-mock-vgs   true         hostpath-mock-vgsc         groupsnapcontent-03314fd3-faa5-4aea-a14b-416b8b47ba86   4h19m          4h19m


[root@node-1 new-crd]# kubectl get vgsc
NAME                                                    READYTOUSE   DELETIONPOLICY   DRIVER                VOLUMEGROUPSNAPSHOTCLASS   VOLUMEGROUPSNAPSHOTNAMESPACE   VOLUMEGROUPSNAPSHOT   AGE
groupsnapcontent-03314fd3-faa5-4aea-a14b-416b8b47ba86   true         Delete           hostpath.csi.ake.io   hostpath-mock-vgsc         default                        hostpath-mock-vgs     4h20m

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@xing-yang @RaunakShah

help me check the feature is ok, thanks

Does this PR introduce a user-facing change?:

More detail printed columns output when get vgs/vgsc/vgsclass with kubectl

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @winrouter!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @winrouter. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2023
@carlory
Copy link
Member

carlory commented Jul 3, 2023

@winrouter please add a release note.

LGTM cc @xing-yang

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 3, 2023
@winrouter
Copy link
Contributor Author

thanks for your review @carlory , your comment have been addressed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2023
@winrouter
Copy link
Contributor Author

thanks for you review, I already fixed it. review again @RaunakShah

@winrouter winrouter requested a review from RaunakShah July 4, 2023 10:27
@RaunakShah
Copy link
Contributor

/lgtm
/approve
Thanks for catching this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2023
@winrouter
Copy link
Contributor Author

/assign @xing-yang

ping @xing-yang for approval

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaunakShah, winrouter, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 304f4bf into kubernetes-csi:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants