Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default timeout in help msg #118

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

xing-yang
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes the help message for the default CSI timeout to 1 minute.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from lpabon and saad-ali April 27, 2019 15:46
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2019
@xing-yang
Copy link
Collaborator Author

@andrewsykim PTAL

@andrewsykim
Copy link
Contributor

/lgtm

Thanks @xing-yang

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit b36da39 into kubernetes-csi:master Apr 27, 2019
mattcary pushed a commit to mattcary/external-snapshotter that referenced this pull request Dec 10, 2020
cloud build: double the timeout, now 1 hour
pohly added a commit to pohly/external-snapshotter that referenced this pull request Dec 18, 2020
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 3b6d17b
dobsonj pushed a commit to dobsonj/external-snapshotter that referenced this pull request Dec 13, 2023
…ncy-openshift-4.15-ose-csi-external-snapshotter

OCPBUGS-24244: Updating ose-csi-external-snapshotter-container image to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants