Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use distroless as base image #101

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Use distroless as base image #101

merged 1 commit into from
Mar 14, 2019

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 12, 2019 •
edited
Loading

Reason: k8s core components move its base images to distroless/static. See kubernetes/kubernetes#70249 (comment) for details.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2019
@xing-yang
Copy link
Collaborator

@jsafrane What is the purpose of this change? Any benefits of using this image?

@jsafrane
Copy link
Contributor Author

I should have included the reason to all PRs.

Reason: k8s core components move its base images to distroless/static. See kubernetes/kubernetes#70249 (comment) for details.

@xing-yang
Copy link
Collaborator

I should have included the reason to all PRs.

Reason: k8s core components move its base images to distroless/static. See kubernetes/kubernetes#70249 (comment) for details.

Can you add this Reason to the Description section on top? Otherwise this looks good to me.

@jsafrane
Copy link
Contributor Author

I updated the description

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 29fe5ab into kubernetes-csi:master Mar 14, 2019
dobsonj pushed a commit to dobsonj/external-snapshotter that referenced this pull request Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-csi#101 from mpatlasov/rebase-v6.2.2
712bf7c 
STOR-1169: Rebase `external-snapshotter` to v6.2.2 for OCP 4.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsafrane @xing-yang @k8s-ci-robot