Add secrets in CreateVolumeGroupSnapshots

[xing-yang]

No description provided.

[nixpanic]

Secrets are passed here

external-snapshotter/pkg/group_snapshotter/group_snapshotter.go

Lines 50 to 64 in a942b5b

	func (gs *groupSnapshot) CreateGroupSnapshot(ctx context.Context, groupSnapshotName string, volumeIDs []string, parameters map[string]string, snapshotterCredentials map[string]string) (string, string, []*csi.Snapshot, time.Time, bool, error) {
	klog.V(5).Infof("CSI CreateGroupSnapshot: %s", groupSnapshotName)
	client := csi.NewGroupControllerClient(gs.conn)
	driverName, err := csirpc.GetDriverName(ctx, gs.conn)
	if err != nil {
	return "", "", nil, time.Time{}, false, err
	}
	req := csi.CreateVolumeGroupSnapshotRequest{
	Name: groupSnapshotName,
	SourceVolumeIds: volumeIDs,
	Secrets: snapshotterCredentials,
	Parameters: parameters,
	}

Is there an other location where you expect secrets to be passed?

[xing-yang]

Currently nothing is passed through snapshotterCredentials. There's a TODO here:
https://github.com/kubernetes-csi/external-snapshotter/blob/master/pkg/sidecar-controller/groupsnapshot_helper.go#L368

See this PR as an example: #165

[carlory]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Madhu-1]

@carlory can you please update on this one, without this support we cannot implement volumegroup in cephcsi driver.

[carlory]

Thanks for your reminder, I didn't start to solve this issue yet. Due to Chinese New Year, I may not have enough bandwidth to solve this issue in the next few days. If you want this changes to be made as soon as possible, feel free to submit a pull request if you are also interested in doing it.

[carlory]

/remove-lifecycle stale

[Madhu-1]

@carlory great thank you, will take care of this one.

/assign @Madhu-1