Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached driver name in SnapshotController instead of getting it from CreateSnapshot #159

Closed
ggriffiths opened this issue Aug 12, 2019 · 5 comments
Closed

Use cached driver name in SnapshotController instead of getting it from CreateSnapshot #159

ggriffiths opened this issue Aug 12, 2019 · 5 comments
Assignees
@a-hilaly
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ggriffiths
Copy link
Member

A comment from @jsafrane in another open PR
#153 (comment)

Specifically, this call can be cached:

external-snapshotter/pkg/snapshotter/snapshotter.go

Line 64 in 7e09056

driverName, err := csirpc.GetDriverName(ctx, s.conn)

@ggriffiths
Copy link
Member Author

ggriffiths commented Aug 21, 2019 •
edited
Loading

This is actually already cached as snapshotterName in the controller. We don't use the driverName inside of external-snapshotter/pkg/snapshotter/snapshotter.go, it's just passed back upstream to the controller.

Instead of doing this, we can have the controller use it's cached version ctrl.snapshotterName. This would mean removing the driverName return value from snapshotter.CreateSnapshot in addition to removing this call:

external-snapshotter/pkg/snapshotter/snapshotter.go

Line 64 in 7e09056

driverName, err := csirpc.GetDriverName(ctx, s.conn)

@ggriffiths ggriffiths changed the title Cache the driver name from csirpc.GetDriverName Use cached driver name in SnapshotController instead of getting it from CreateSnapshot Aug 21, 2019
@jsafrane
Copy link
Contributor

jsafrane commented Sep 2, 2019

Sure, removing driverName return value is OK.

@ggriffiths
Copy link
Member Author

/good-first-issue
/help
/kind cleanup

@k8s-ci-robot
Copy link
Contributor

@ggriffiths:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 3, 2019
@ggriffiths ggriffiths mentioned this issue Oct 18, 2019
Closed
6 tasks
@a-hilaly
Copy link

a-hilaly commented Nov 2, 2019

/assign

@a-hilaly a-hilaly mentioned this issue Nov 5, 2019
Closed
@ggriffiths ggriffiths mentioned this issue Dec 11, 2019
Closed
6 tasks
xing-yang added a commit to xing-yang/external-snapshotter that referenced this issue Jul 20, 2021
@xing-yang
Squashed 'release-tools/' changes from bc0504a..c0a4fb1
9eb9a93 
c0a4fb1 Merge pull request kubernetes-csi#164 from anubha-v-ardhan/patch-1
9c6a6c0 Master to main cleanup
682c686 Merge pull request kubernetes-csi#162 from pohly/pod-name-via-shell-command
36a29f5 Merge pull request kubernetes-csi#163 from pohly/remove-bazel
68e43ca prow.sh: remove Bazel build support
c5f59c5 prow.sh: allow shell commands in CSI_PROW_SANITY_POD
71c810a Merge pull request kubernetes-csi#161 from pohly/mock-test-fixes
9e438f8 prow.sh: fix mock testing
d7146c7 Merge pull request kubernetes-csi#160 from pohly/kind-update
4b6aa60 prow.sh: update to KinD v0.11.0
7cdc76f Merge pull request kubernetes-csi#159 from pohly/fix-deployment-selection
ef8bd33 prow.sh: more flexible CSI_PROW_DEPLOYMENT, part II
204bc89 Merge pull request kubernetes-csi#158 from pohly/fix-deployment-selection
61538bb prow.sh: more flexible CSI_PROW_DEPLOYMENT
2b0e6db Merge pull request kubernetes-csi#157 from humblec/csi-release
a2fcd6d Adding myself to csi reviewers group
f325590 Merge pull request kubernetes-csi#149 from pohly/cluster-logs
4b03b30 Merge pull request kubernetes-csi#155 from pohly/owners
a6453c8 owners: introduce aliases
ad83def Merge pull request kubernetes-csi#153 from pohly/fix-image-builds
5561780 build.make: fix image publishng
29bd39b Merge pull request kubernetes-csi#152 from pohly/bump-csi-test
bc42793 prow.sh: use csi-test v4.2.0
b546baa Merge pull request kubernetes-csi#150 from mauriciopoppe/windows-multiarch-args
bfbb6f3 add parameter base_image and addon_image to BUILD_PARAMETERS
2d61d3b Merge pull request kubernetes-csi#151 from humblec/cm
48e71f0 Replace `which` command ( non standard)  with `command -v` builtin
feb20e2 prow.sh: collect cluster logs
7b96bea Merge pull request kubernetes-csi#148 from dobsonj/add-checkpathcmd-to-prow
2d2e03b prow.sh: enable -csi.checkpathcmd option in csi-sanity
09d4151 Merge pull request kubernetes-csi#147 from pohly/mock-testing
74cfbc9 prow.sh: support mock tests
4a3f110 prow.sh: remove obsolete test suppression
6616a6b Merge pull request kubernetes-csi#146 from pohly/kubernetes-1.21
510fb0f prow.sh: support Kubernetes 1.21
c63c61b prow.sh: add CSI_PROW_DEPLOYMENT_SUFFIX
51ac11c Merge pull request kubernetes-csi#144 from pohly/pull-jobs
dd54c92 pull-test.sh: test importing csi-release-tools into other repo
7d2643a Merge pull request kubernetes-csi#143 from pohly/path-setup
6880b0c prow.sh: avoid creating paths unless really running tests

git-subtree-dir: release-tools
git-subtree-split: c0a4fb1
xing-yang pushed a commit to xing-yang/external-snapshotter that referenced this issue Jul 26, 2021
@k8s-ci-robot
Merge pull request kubernetes-csi#159 from pohly/fix-deployment-selec…
7cdc76f 
…tion

prow.sh: more flexible CSI_PROW_DEPLOYMENT, part II
rhrmo pushed a commit to rhrmo/external-snapshotter that referenced this issue Oct 2, 2024
@openshift-merge-bot
Merge pull request kubernetes-csi#159 from openshift-bot/art-consiste…
1704e4d 
…ncy-openshift-4.17-ose-csi-snapshot-controller

OCPBUGS-34292: Updating ose-csi-snapshot-controller-container image to be consistent with ART for 4.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-hilaly a-hilaly

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove driver name from Snapshotter CreateSnapshot return values a-hilaly/external-snapshotter
4 participants
@ggriffiths @jsafrane @a-hilaly @k8s-ci-robot