Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary warning when PV bound to PVC is not created yet #172

Merged

Conversation

takuhiro
Copy link
Contributor

@takuhiro takuhiro commented Aug 18, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR adds the empty check of pvc.Spec.VolumeName before getting the PV to avoid an unnecessary warning here that is logged every time a new PVC is created.

before:

I0816 07:50:11.380497       1 controller.go:291] Started PVC processing "default/sample-volume-jtdql"
W0816 07:50:11.380594       1 controller.go:318] PV "" bound to PVC default/sample-volume-jtdql not found

after:

I0818 08:00:08.852855       1 controller.go:291] Started PVC processing "default/sample-volume-v2784"
I0818 08:00:08.855161       1 controller.go:314] PV bound to PVC "default/sample-volume-v2784" is not created yet

Which issue(s) this PR fixes:

Fixes #170

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix unnecessary warning when PV bound to PVC is not created yet.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 18, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @takuhiro!

It looks like this is your first PR to kubernetes-csi/external-resizer 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-resizer has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @takuhiro. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2021
@gnufied
Copy link
Contributor

gnufied commented Aug 18, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2021
@takuhiro
Copy link
Contributor Author

@gnufied Thank you for running tests. Could you merge this?

@takuhiro
Copy link
Contributor Author

@gnufied @jingxu97 @humblec Could you approve and merge this PR?

@gnufied
Copy link
Contributor

gnufied commented Sep 30, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, takuhiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9e96b40 into kubernetes-csi:master Sep 30, 2021
@takuhiro takuhiro deleted the fix-unnecessary-warning branch October 1, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csi-resizer logs a warning every time a new PVC is created
3 participants