-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unnecessary warning when PV bound to PVC is not created yet #172
Fix unnecessary warning when PV bound to PVC is not created yet #172
Conversation
Welcome @takuhiro! |
Hi @takuhiro. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@gnufied Thank you for running tests. Could you merge this? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, takuhiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds the empty check of pvc.Spec.VolumeName before getting the PV to avoid an unnecessary warning here that is logged every time a new PVC is created.
before:
after:
Which issue(s) this PR fixes:
Fixes #170
Special notes for your reviewer:
Does this PR introduce a user-facing change?: