-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example YAMLs for deploying external-resizer #16
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# This YAML file demonstrates how to deploy the external | ||
# resizer for use with the mock CSI driver. It | ||
# depends on the RBAC definitions from rbac.yaml. | ||
|
||
kind: Deployment | ||
apiVersion: apps/v1 | ||
metadata: | ||
name: csi-resizer | ||
spec: | ||
replicas: 1 | ||
selector: | ||
matchLabels: | ||
external-resizer: mock-driver | ||
template: | ||
metadata: | ||
labels: | ||
external-resizer: mock-driver | ||
spec: | ||
serviceAccount: csi-resizer | ||
containers: | ||
- name: csi-resizer | ||
image: quay.io/k8scsi/csi-resizer | ||
args: | ||
- "--v=5" | ||
- "--csi-address=$(ADDRESS)" | ||
- "--leader-election" | ||
- "--leader-election-namespace=$(MY_NAMESPACE)" | ||
- "--leader-election-identity=$(MY_NAME)" | ||
env: | ||
- name: MY_NAME | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: metadata.name | ||
- name: MY_NAMESPACE | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: metadata.namespace | ||
- name: ADDRESS | ||
value: /var/lib/csi/sockets/pluginproxy/mock.socket | ||
imagePullPolicy: "IfNotPresent" | ||
volumeMounts: | ||
- name: socket-dir | ||
mountPath: /var/lib/csi/sockets/pluginproxy/ | ||
|
||
- name: mock-driver | ||
image: quay.io/k8scsi/mock-plugin | ||
imagePullPolicy: "IfNotPresent" | ||
env: | ||
- name: CSI_ENDPOINT | ||
value: /var/lib/csi/sockets/pluginproxy/mock.socket | ||
volumeMounts: | ||
- name: socket-dir | ||
mountPath: /var/lib/csi/sockets/pluginproxy/ | ||
|
||
volumes: | ||
- name: socket-dir | ||
emptyDir: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
# This YAML file contains all RBAC objects that are necessary to run external | ||
# CSI resizer. | ||
# | ||
# In production, each CSI driver deployment has to be customized: | ||
# - to avoid conflicts, use non-default namespace and different names | ||
# for non-namespaced entities like the ClusterRole | ||
# - decide whether the deployment replicates the external CSI | ||
# resizer, in which case leadership election must be enabled; | ||
# this influences the RBAC setup, see below | ||
|
||
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: csi-resizer | ||
# replace with non-default namespace name | ||
namespace: default | ||
|
||
--- | ||
# Resizer must be able to work with PVCs, PVs, SCs. | ||
kind: ClusterRole | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: external-resizer-runner | ||
rules: | ||
# The following rule should be uncommented for plugins that require secrets | ||
# for provisioning. | ||
# - apiGroups: [""] | ||
# resources: ["secrets"] | ||
# verbs: ["get", "list", "watch"] | ||
- apiGroups: [""] | ||
resources: ["persistentvolumes"] | ||
verbs: ["get", "list", "watch", "update", "patch"] | ||
- apiGroups: [""] | ||
resources: ["persistentvolumeclaims"] | ||
verbs: ["get", "list", "watch"] | ||
- apiGroups: [""] | ||
resources: ["persistentvolumeclaims/status"] | ||
verbs: ["update", "patch"] | ||
- apiGroups: ["storage.k8s.io"] | ||
resources: ["storageclasses"] | ||
verbs: ["get", "list", "watch"] | ||
- apiGroups: [""] | ||
resources: ["events"] | ||
verbs: ["list", "watch", "create", "update", "patch"] | ||
|
||
--- | ||
kind: ClusterRoleBinding | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: csi-resizer-role | ||
subjects: | ||
- kind: ServiceAccount | ||
name: csi-resizer | ||
# replace with non-default namespace name | ||
namespace: default | ||
roleRef: | ||
kind: ClusterRole | ||
name: external-resizer-runner | ||
apiGroup: rbac.authorization.k8s.io | ||
|
||
--- | ||
# Resizer must be able to work with end point in current namespace | ||
# if (and only if) leadership election is enabled | ||
kind: Role | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
# replace with non-default namespace name | ||
namespace: default | ||
name: external-resizer-cfg | ||
rules: | ||
- apiGroups: [""] | ||
resources: ["endpoints"] | ||
verbs: ["get", "watch", "list", "delete", "update", "create"] | ||
|
||
--- | ||
kind: RoleBinding | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: csi-resizer-role-cfg | ||
# replace with non-default namespace name | ||
namespace: default | ||
subjects: | ||
- kind: ServiceAccount | ||
name: csi-resizer | ||
# replace with non-default namespace name | ||
namespace: default | ||
roleRef: | ||
kind: Role | ||
name: external-resizer-cfg | ||
apiGroup: rbac.authorization.k8s.io |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be consistent with other external components that mostly use "/csi/csi.sock" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently only external snapshotter uses
/csi/csi.sock
: https://github.com/kubernetes-csi/external-snapshotter/blob/f59b58d16488bbb9c15a263bf1b2685c3c4c4441/deploy/kubernetes/setup-csi-snapshotter.yaml#L94, both provisioner and attacher use/var/lib/csi/sockets/pluginproxy/mock.socket
: https://github.com/kubernetes-csi/external-provisioner/blob/f588078fd1f33dd7e9557cceba4c05e3562683fd/deploy/kubernetes/statefulset.yaml#L41, https://github.com/kubernetes-csi/external-attacher/blob/0e6f5f22774f89d2d2c396896c462a4fb3587902/deploy/kubernetes/deployment.yaml#L53.So I tend to be consistent with the provisioner and attacher as they all use
mock driver
, while snapshotter useshostpath
.