Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.1: update release-tools + OWNERS #153

Merged

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 21, 2021

Squashed 'release-tools/' changes from 6616a6b..f325590

f325590 Merge pull request #149 from pohly/cluster-logs
4b03b30 Merge pull request #155 from pohly/owners
a6453c8 owners: introduce aliases
ad83def Merge pull request #153 from pohly/fix-image-builds
5561780 build.make: fix image publishng
29bd39b Merge pull request #152 from pohly/bump-csi-test
bc42793 prow.sh: use csi-test v4.2.0
b546baa Merge pull request #150 from mauriciopoppe/windows-multiarch-args
bfbb6f3 add parameter base_image and addon_image to BUILD_PARAMETERS
2d61d3b Merge pull request #151 from humblec/cm
48e71f0 Replace which command ( non standard) with command -v builtin
feb20e2 prow.sh: collect cluster logs
7b96bea Merge pull request #148 from dobsonj/add-checkpathcmd-to-prow
2d2e03b prow.sh: enable -csi.checkpathcmd option in csi-sanity
09d4151 Merge pull request #147 from pohly/mock-testing
74cfbc9 prow.sh: support mock tests
4a3f110 prow.sh: remove obsolete test suppression

git-subtree-dir: release-tools
git-subtree-split: f3255906abf2e4134cb3db4ff79ddfb5ce1e91aa

NONE

pohly added 2 commits May 21, 2021 09:58
kubernetes-csi/csi-release-tools@f325590 Merge kubernetes-csi/csi-release-tools#149 from pohly/cluster-logs
kubernetes-csi/csi-release-tools@4b03b30 Merge kubernetes-csi/csi-release-tools#155 from pohly/owners
kubernetes-csi/csi-release-tools@a6453c8 owners: introduce aliases
kubernetes-csi/csi-release-tools@ad83def Merge kubernetes-csi/csi-release-tools#153 from pohly/fix-image-builds
kubernetes-csi/csi-release-tools@5561780 build.make: fix image publishng
kubernetes-csi/csi-release-tools@29bd39b Merge kubernetes-csi/csi-release-tools#152 from pohly/bump-csi-test
kubernetes-csi/csi-release-tools@bc42793 prow.sh: use csi-test v4.2.0
kubernetes-csi/csi-release-tools@b546baa Merge kubernetes-csi/csi-release-tools#150 from mauriciopoppe/windows-multiarch-args
kubernetes-csi/csi-release-tools@bfbb6f3 add parameter base_image and addon_image to BUILD_PARAMETERS
kubernetes-csi/csi-release-tools@2d61d3b Merge kubernetes-csi/csi-release-tools#151 from humblec/cm
kubernetes-csi/csi-release-tools@48e71f0 Replace `which` command ( non standard)  with `command -v` builtin
kubernetes-csi/csi-release-tools@feb20e2 prow.sh: collect cluster logs
kubernetes-csi/csi-release-tools@7b96bea Merge kubernetes-csi/csi-release-tools#148 from dobsonj/add-checkpathcmd-to-prow
kubernetes-csi/csi-release-tools@2d2e03b prow.sh: enable -csi.checkpathcmd option in csi-sanity
kubernetes-csi/csi-release-tools@09d4151 Merge kubernetes-csi/csi-release-tools#147 from pohly/mock-testing
kubernetes-csi/csi-release-tools@74cfbc9 prow.sh: support mock tests
kubernetes-csi/csi-release-tools@4a3f110 prow.sh: remove obsolete test suppression

git-subtree-dir: release-tools
git-subtree-split: f3255906abf2e4134cb3db4ff79ddfb5ce1e91aa
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 21, 2021
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali May 21, 2021 07:59
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2021
@pohly pohly force-pushed the prow-update-release-1.1 branch from ccf3268 to 24f2c6c Compare May 21, 2021 08:04
@pohly pohly changed the title WIP: release-1.1: update release-tools + OWNERS release-1.1: update release-tools + OWNERS May 21, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2021
@pohly
Copy link
Contributor Author

pohly commented May 21, 2021

/retest

@pohly
Copy link
Contributor Author

pohly commented May 21, 2021

/hold

For clarification from @mlmhl - see #152 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2021
@pohly
Copy link
Contributor Author

pohly commented May 21, 2021

/retest

1 similar comment
@pohly
Copy link
Contributor Author

pohly commented May 22, 2021

/retest

@pohly pohly force-pushed the prow-update-release-1.1 branch from 24f2c6c to 5dca85e Compare May 26, 2021 07:27
@pohly
Copy link
Contributor Author

pohly commented May 26, 2021

/hold cancel

I kept @mlmhl as approver and moved them to "emeritus_reviewer". The rationale is that reviewers should be known to be active and responsive, and both doesn't seem to be the case here. This can of course be changed again.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2021
@pohly
Copy link
Contributor Author

pohly commented May 31, 2021

/assign @gnufied

Please take another look - I'd like to finalize the OWNERS changes.

@gnufied
Copy link
Contributor

gnufied commented Jun 1, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@gnufied
Copy link
Contributor

gnufied commented Jun 1, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2021
@gnufied
Copy link
Contributor

gnufied commented Jun 1, 2021

oh I see we have 2 PRs to two different branches.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit df4a4d8 into kubernetes-csi:release-1.1 Jun 1, 2021
@pohly pohly deleted the prow-update-release-1.1 branch July 6, 2021 08:55
dobsonj pushed a commit to dobsonj/external-resizer that referenced this pull request Mar 1, 2024
STOR-1688: Chore: add .snyk file to ignore false positives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants